PAINTROID-455 Add Color Picker

[bhav-khurana]

Ticket

PAINTROID 455

New Features and Enhancements

Added the functionality to choose from a set of defined colors, adjust the alpha value.
Implemented a custom color picker as a separate module

Checklist

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

• Include the name of the Jira ticket in the PR’s title
• Include a summary of the changes plus the relevant context
• Choose the proper base branch (develop)
• Confirm that the changes follow the project’s coding guidelines
• Verify that the changes generate no compiler or linter warnings
• Perform a self-review of the changes
• Verify to commit no other files than the intentionally changed ones
• Include reasonable and readable tests verifying the added or changed behavior
• Confirm that new and existing unit tests pass locally
• Check that the commits’ message style matches the project’s guideline
• Stick to the project’s gitflow workflow
• Verify that your changes do not have any conflicts with the base branch
• After the PR, verify that all CI checks have passed
• Post a message in the #paintroid Slack channel and ask for a code reviewer

[bhav-khurana]

@juliajulie95 @bakicelebi Can you please suggest any possible changes?

[juliajulie95]

Hi!
Thanks for your interest in the project, but this ticket duplicates one we already have:
https://jira.catrob.at/browse/PAINTROID-455
If you want to contribute, check out this ticket and adjust your color picker :)
Minimal design changes from the old design are okay, but we need the functionality to be the same

[bhav-khurana]

Sure! I will look into the ticket and adjust it as required.

[bhav-khurana]

@juliajulie95 Should the design and look of the color picker be same as in the original app? There's a similar design based on the flutter_colorpicker package.

Can I integrate this in the app?

[juliajulie95]

The color picker will also be used in our other apps so we would like to implement it oursselves instead of being dependent on other libraries :)

[bhav-khurana]

Okay sure! Will try to implement the color picker as per the requirements

[bhav-khurana]

@juliajulie95 I have made a colorpicker package and used in the code as required. Can you please review?

[juliajulie95]

Please rename the PR to PAINTROID-455 so it gets tracked on our jira board

[bhav-khurana]

@juliajulie95 I have renamed the PR as required

[juliajulie95]

Please resolve your conflicts :)

[bhav-khurana]

@juliajulie95 I have resolved the conflicts. Please have a look

[bhav-khurana]

@juliajulie95 Are there any other changes required?

[juliajulie95]

@bhav-khurana Thank you!
Your ticket is currently waiting for Coder review, after that I will review and merge if accepted.
Thank you for your patience, as we are still a small team of developers/students and are not working full-time at Catrobat.

[bhav-khurana]

Okay, thank you so much!

[msesko]

@juliajulie95 should this be a separate package or do we just put it in tools? There is not that much code so that is not the issue. I am just not sure if it is considered a tools or something else.

[msesko]

@juliajulie95 should this be a separate package or do we just put it in tools? There is not that much code so that is not the issue. I am just not sure if it is considered a tools or something else.

-> seperate package is good: we also need to build it seperately for the PocketCode app

[bhav-khurana]

@juliajulie95 should this be a separate package or do we just put it in tools? There is not that much code so that is not the issue. I am just not sure if it is considered a tools or something else.

-> seperate package is good: we also need to build it seperately for the PocketCode app

Yes I think it should be in a separate package only as it is in the original app.. we can add more functionalities to the colorpicker in future too

[msesko]

@bhav-khurana Good job on coding. Please check my requested changes in comments. Hopefully they make sense :). Also resolve conflicts with develop if there are any.

[msesko]

Hi, bhav. Tested on iOS, works good. Please just do this one fix I commented and then we should be good to do a QA review :)

[msesko]

Good.

[juliajulie95]

Hi @bhav-khurana
Looks very good.
One issue I found is, when I go into the colorpicker the first color is selected immediately.
When opening the current color should be selected until the user selects another color.
So opening the colorpicker and hitting "Apply" without tapping any color, should result in having the same color selected as before opening the color picker
Please ping me when this is done

[juliajulie95]

A second issue I found:
When I paint with opacity the opacity changes when doing the next stroke
Let me know if you can't reproduce and need videos

[bhav-khurana]

Hi @juliajulie95
I have resolved the first issue but I'm not really sure of why the latter still persists, I can reproduce the same and even tried debugging it; maybe the old instance gets overwritten or something like that

[msesko]

A second issue I found: When I paint with opacity the opacity changes when doing the next stroke Let me know if you can't reproduce and need videos

This is something I have also pointed out before.

[juliajulie95]

Please resolve the conflicts.
Please check that if you do make get/all etc. then it also does that for the colorpicker module
We already had that before the restructure, you can check on how to do that there
For the bug, i think we will merge it like that and I will create a bug ticket for that

[juliajulie95]

Seems like it doesn't work anymore.
Please also add tests for the functionality

[bhav-khurana]

@juliajulie95
Which tests are you talking about? Tests for color and opacity updates have already been added

[juliajulie95]

For example tests for the problem with the opacity changing on the next stroke :)

[juliajulie95]

Please resolve the conflicts
There are still a few issues with opacity, but I would create a bug ticket for those.

• Opacity changing after finishing the current stroke and when next stroke is started
• Opacity changing does not work if you do not change the color in the dialog
• Opacity slider is always on max opacity if you return to the dialog even with a color with opacity

Reviewed