Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAINTROID-591 Add Makefile #38

Merged
merged 1 commit into from
Nov 16, 2023
Merged

PAINTROID-591 Add Makefile #38

merged 1 commit into from
Nov 16, 2023

Conversation

Lenkomotive
Copy link
Contributor

@Lenkomotive Lenkomotive commented Nov 16, 2023 •
edited
Loading

PAINTROID-591

Added simple makefile for basic flutter functionality.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #paintroid Slack channel and ask for a code reviewer

bakicelebi
bakicelebi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@bakicelebi bakicelebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Lenkomotive Lenkomotive merged commit 4ef9f81 into Catrobat:develop Nov 16, 2023
1 check passed
@Lenkomotive Lenkomotive deleted the PAINTROID-591 branch November 16, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakicelebi bakicelebi bakicelebi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lenkomotive @bakicelebi