Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARE-555 child restriction #139

Merged
merged 1 commit into from
Feb 23, 2024
Merged

SHARE-555 child restriction #139

merged 1 commit into from
Feb 23, 2024

Conversation

makne17
Copy link
Contributor

@makne17 makne17 commented Jan 10, 2024

added new not_for_kids property to ProjectResponse


Your checklist for this pull request

Please review the contributing guidelines of this repository.

  • Include the name and id of the Jira ticket in the PR’s title eg.: SHARE-666 The devils ticket
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no warnings and errors
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Verify that all tests are passing, if not please state the test cases in the section below
  • Perform a self-review of the changes
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • Put your ticket into the Code Review section in Jira
  • Post a message in the #catroweb Slack channel and ask for a code reviewer

Additional Description

TODO: Add additional information that is not in your commit-message here

Tests - additional information

TODO: add additional information about testruns here

added new not_for_kids property to ProjectResponse
@makne17 makne17 requested a review from dmetzner February 3, 2024 17:10
@dmetzner dmetzner merged commit 4bcdfbd into Catrobat:main Feb 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants