Less verbose strings #645
Less verbose strings #645
Conversation
|
I just link to the discussion that happened on weblate, if someone wants to look at it : https://hosted.weblate.org/translate/catima/catima/en/?checksum=f2122da997dfe989#comments |
There was a problem hiding this comment.
There are definitely multiple places where we can remove the word "card" without any issues and I support removing them there. You just changed it in places where it makes stuff unclear as well. Mind undoing the places I mentioned, so I can merge this with the places where we can remove the word "card" easily without harming clarity?
app/src/main/res/values/strings.xml
Outdated
| <item quantity="one"><xliff:g>%d</xliff:g> card</item> | ||
| <item quantity="other"><xliff:g>%d</xliff:g> cards</item> | ||
| <item quantity="one"><xliff:g>%d</xliff:g></item> | ||
| <item quantity="other"><xliff:g>%d</xliff:g></item> |
There was a problem hiding this comment.
You're changing "2 cards" to "2" here. Will look awful and be very confusing for users to see a number with no explanation.
There was a problem hiding this comment.
For another day: Maybe it could be a visual representation? [barcodeemoji] x 2 [coupon] x3 [?] x 4
Or [barcodeemoji][barcodeemoji][coupon][coupon][coupon][?][?][?][?]
There was a problem hiding this comment.
That could be possible maybe, assuming we can tell Android to use the old text for screen readers. But at that point we just turn it into 2 strings to manage.
|
My initial niggle was to get rid of "Loyalty card", because "card" is less restrictive. |
app/src/main/res/values/strings.xml
Outdated
| @@ -29,12 +29,12 @@ | |||
| For example, in Russian, Android's plural quantity "one" actually refers to "any number ending on 1 but not ending in 11". | |||
| So while in English the extra non-plural form seems unnecessary duplication, it is necessary to give translators enough flexibility. | |||
| In Catima, we use the plain string when meaning exactly 1, and otherwise use the plural forms --> | |||
| <string name="deleteTitle">Delete card</string> | |||
| <string name="deleteTitle">Deletion</string> | |||
There was a problem hiding this comment.
Please read the i18n oddness note as to why it makes no sense to make deleteTitle so different to deleteCardsTitle.
app/src/main/res/values/strings.xml
Outdated
| <plurals name="deleteCardsTitle"> | ||
| <item quantity="one">Delete <xliff:g>%d</xliff:g> card</item> | ||
| <item quantity="other">Delete <xliff:g>%d</xliff:g> cards</item> | ||
| </plurals> | ||
| <string name="deleteConfirmation">Delete this card permanently?</string> | ||
| <string name="deleteConfirmation">Delete this permanently?</string> |
There was a problem hiding this comment.
Please read the i18n oddness note as to why it makes no sense to make deleteConfirmation so different to deleteCardsConfirmation.
app/src/main/res/values/strings.xml
Outdated
| <string name="importing">Importing…</string> | ||
| <string name="exporting">Exporting…</string> | ||
| <string name="noExternalStoragePermissionError">Grant external storage permission to import or export cards first</string> | ||
| <string name="noExternalStoragePermissionError">Grant external storage permission to import or export first</string> |
There was a problem hiding this comment.
While we're changing these anyway, "to import or export data" makes more sense.
app/src/main/res/values/strings.xml
Outdated
| </plurals> | ||
| <string name="noGiftCards">Click the + plus button to add a card, or import some from the ⋮ menu first.</string> | ||
| <string name="noGiftCardsGroup">You don\'t have any loyalty cards yet. Once you\'ve added some you can assign them to the group here.</string> | ||
| <string name="noMatchingGiftCards">Didn\'t find anything. Try changing your search.</string> | ||
| <string name="noGiftCardsGroup">If you add some cards you can assign them to this group afterwards.</string> |
There was a problem hiding this comment.
I'm not a fan of changing this from "here" to "afterwards", because this appears exactly at the UI location where you can choose which cards belong to a group. The old string is very explicitly: "once you have created cards, come back to this screen to add them to this group". The new one is vague "if you do X you can do Y after that".
Co-authored-by: Allan Nordhøy <[email protected]>
|
I honestly am still not convinced "reverse-side" is better than "back", especially given I hadn't even heard of this term until you mentioned it at all. And it has been nagging on me all day it just feels wrong. So I guess I am going to put my foot down here and insist we just go with front/back, to keep it simple and easy to understand |
|
@TheLastProject Fixed. I am not certain "reverse side" is better, but there is the UK meaning of "backside" to worry about. |
| <string name="frontImageDescription">Card\'s front image</string> | ||
| <string name="backImageDescription">Card\'s back image</string> | ||
| <string name="frontImageDescription">Front-side image</string> | ||
| <string name="backImageDescription">Back-side image</string> | ||
| <string name="photos">Photos</string> | ||
| <string name="setFrontImage">Set front image</string> |
There was a problem hiding this comment.
Now there is still some inconsistency...
<string name="frontImageDescription">Front-side image</string>
<string name="setFrontImage">Set front image</string>
What is wrong with just "Front image" and "Back image" as I've mentioned several times? You keep changing it differently anyway, without telling me why my suggestion (which is what we've been using for years now) is apparently wrong.
There was a problem hiding this comment.
Sorry, didn't think that was an option. Nor did I notice the inconsistency. Bit out of it on the whole,
Tried.