Added Notification feature #579
Conversation
# Conflicts: # app/src/main/java/protect/card_locker/Notification.java
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardEditActivity.java
Outdated
Show resolved
Hide resolved
|
Found some more little things. By the way, this should move to the database at some point. Do you want me to try to teach you how to do that or would you rather I write the database parts myself? I don't know if you are contributing because you want this feature in Catima or because you want to learn more Android development, so I don't want to make you do more work unless you want to :) |
|
I am working on it.👍 |
There was a problem hiding this comment.
The base code looks mostly okay (although it wouldn't hurt to run "Reformat code" in Android Studio).
There are several issues reported by SpotBugs though, you can run it yourself locally or download the check results from GitHub CI:
- Press Details
- Press Summary
- Scroll down and download test-results
Aside from that, time to switch to the DB stuff? You should probably create something similar to groups so that one card could have multiple alarms. So, define a LoyaltyCardDbAlarms and LoyaltyCardDbIdsAlarms class and add it to onCreate. Then you also want to increase DATABASE_VERSION and add something to the onUpgrade to also create the new tables when users upgrade from an old version (onCreate is only ran during a clean install).
After that we also need to make sure import/export of that works, but let's do the DB part first :)
|
Hey, I haven't heard about this PR for a while so I'll close it to keep the PR list clean. If you ever want to finish this, feel free to reopen. Thanks for your help :) |
Please review the changes.
resolves #410