Improve barcode rendering (square codes & padding)

[obfusk]

Fixes #1332.

screenshots

[obfusk]

Might also fix #329.

[obfusk]

Explanation

The current code doesn't take square barcodes into account, thus incorrectly reducing the height to match the max width using a wrong aspect ratio. I changed that to use the minimum of the height, width, and max width for both height and width (since it's square). Which results in better rendering (and no weird padding) for square barcodes like Aztec.

It also adds padding for the rounded corners by reducing the height of the image itself, which I replaced by adding actual padding to either the height or width of the imageView, depending on which is more appropriate given the shape of the barcode and whether the imageView is landscape or portrait. Which should result in no "unnecessary" padding being added in many cases, especially for square barcodes.

[obfusk]

incorrectly reducing the height to match the max width using a wrong aspect ratio

It was scaling the height to match the max width, but using the aspect ratio of the imageView, ignoring the fact that the image should be square for a square barcode.

[obfusk]

Which should result in no "unnecessary" padding being added in many cases, especially for square barcodes.

For a square barcode on a landscape imageView, there is zero point in adding padding to the top and bottom for rounded corners. It still adds padding, but to the left and right in this case, so it's not noticeable now as it doesn't make the barcode itself smaller any more.

[obfusk]

It was scaling the height to match the max width, but using the aspect ratio of the imageView, ignoring the fact that the image should be square for a square barcode.

This was causing both weird padding (on some devices, it was not consistent between my phone and the emulator) and blurred images because of the wrong resolution, which is why I think it might fix #329.

[TheLastProject]

Well, especially with your explanation it makes sense to me. I'm not seeing anything wrong from some quick testing. I'm going to merge it, if more testing shows issues later I can always revert easily anyway :)

[obfusk]

I found one case that got worse. According to CatimaBarcode.isSquare(), Data Matrix is square. This does not seem to be true for all values: