Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customise correction level for QR codes #939

Open
danielphan2003 opened this issue Jul 16, 2022 · 8 comments
Open

Customise correction level for QR codes #939

danielphan2003 opened this issue Jul 16, 2022 · 8 comments
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: minor Impairs non-critical functionality or suitable workarounds exist type: enhancement New feature or request

Comments

@danielphan2003
Copy link

I'm trying to use VietQRs in Catima. They're basically QR codes that have bank number infos for easier money transfer. When I used the QR generated by Catima, banking apps doesn't recognize it because by default VietQRs use correction level H, while Catima uses level L.

@TheLastProject
Copy link
Member

It sucks VietQR doesn't just accept any valid QR code but adds extra restrictions :(

Anyway, are you sure it's the correction level? Is it not a compact QR code instead of a regular QR code? Just double-checking if the issue may not actually be a duplicate of #506 instead.

@danielphan2003
Copy link
Author

Aaactually it was a glitch. I tested with another app and it works. After that I retried with the original app and it also works. ;) but I think it might be nice to be able to customise it.

@TheLastProject
Copy link
Member

Probably should become possible yeah, because it won't surprise me if some developer ends up only allowing a certain correction level. At least the correction level should be kept when scanning an existing code.

@TheLastProject TheLastProject added type: enhancement New feature or request severity: minor Impairs non-critical functionality or suitable workarounds exist common: uncommon Most users are unlikely to come across this or unexpected workflow and removed state: needs info labels Jul 16, 2022
@m-alice
Copy link

m-alice commented Sep 2, 2022

Also, QR have a variations. My local shop uses 21x21 version, and local phone carrier uses 177x177 (probably).

@TheLastProject
Copy link
Member

I think you may be talking about QR_COMPACT there? I still need to get to implementing support for that: #506 (although normally it shouldn't matter, they're both QR codes of the same data, just some scanners are overly picky for no real reason).

@m-alice
Copy link

m-alice commented Sep 2, 2022

image
Sorry for this bedsheet
Maybe i should create a new issue for this?

@TheLastProject
Copy link
Member

I think Catima should already be supporting all of those and automatically choose the right one based on the amount of data.

If you have any actual issue with something not working, feel free to create a new issue.

@OmlineEditor
Copy link

I think we need to make sure that the error correction level is selected exactly the same as on the scanned image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common: uncommon Most users are unlikely to come across this or unexpected workflow severity: minor Impairs non-critical functionality or suitable workarounds exist type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants