-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joyn: wrong QR-code #231
Comments
There is not necessarily anything wrong. The important part is that the content of both codes are the same. The reason there can be differences are because there are multiple different ways to encode the same text and Catima works as follows:
The part that is most confusing is that your joyn loyalty card says I would think this should still work fine in stores (please tell me if it does or doesn't!). There are however a few things that can be done to make the user experience better:
I'll work on 1 and possibly 2. Would be great if the community could help with some things too. Thanks for your report, it helps me improve the app! |
Okay, I have implemented the first of this in 929633e. |
Reading this report rang a bell as I have seen this behaviour (whole URL encoded, QR code on card and encoded by Catima look differently) before but didn't mind. Also, my cards from:
Testing all three (incl. on4aut's Joyn card) with Stocard, encodes the same QR codes as Catima does. Therefore, I believe it's due to an unusual error correcting level those shops use encoding their codes on the cards. It would require some time playing around with a barcode encoder to figure out the exact error correction level these shops use. I don't think its required though as long as the differently looking codes work. I have tested 929633e with my two cards, and it works fine! Thank you! However, I discovered a bug when exporting and importing cards with different Card IDs and barcode value. I created a separate issue for it #235. |
Today I went back to the shop, and I used the QR-code as generated by Catima - and it worked ! |
I noticed a similar phenomenon with Monoprix loyalty card barcodes ("card number" under the barcode doesn't correspond at all with the barcode itself), if we are going to start maintaining a whole list of services with these kinds of annoying quirks 😅 |
I have been looking for an app to store exact copies of QR codes (other than a photo or scan) but so far have not found one. |
@JohnDoe-JohnDoe I think you're looking for #506 and #244 instead, as that issue is about generated barcodes differing from the scanned barcodes in minor ways. This issue is about how the value displayed below the physical Joyn loyalty card isn't actually the same as the value stored in the QR code. |
@TheLastProject Not really, the original post states "I scanned a card with a QR-code in the app Catima. |
Okay, I hadn't read the original report clearly then. However, the part you are talking about is described in more details in #506 so I still believe that is a better issue for this. The simple answer to "Why can't the data be stored without decoding" is because that's not how it correctly works and, if zxing (the library that Catima uses to detect and read the barcode) supports exposing that info (I haven't checked), would require a complete rewrite of many core parts of the app. It would also require complete new code to show barcodes and a second codepath for the case of users manually entering a barcode instead of scanning it with their camera (while this is currently one shared codepath). It also requires a big change to the database format, requiring a migration path for all existing barcodes. So, while it sounds simpler, it is actually the more difficult path to walk given the current codebase. |
The same situation: (on the left is the original QR code from another application for storing loyalty cards, on the right is a screenshot of Catima scanning this code). It can be seen that the QR codes are different. A QR code is a text string, a web link to a description of the store's loyalty program. I have not yet checked whether the new QR code works, but it confuses me when the “copied” QR code differs from the appearance of the QR code on the plastic card. |
It's indeed the same "issue": Catima just asks zxing to generate a QR code of a certain size and it auto-picks a reasonable error correction level which might not be the same as the original so the code may differ (even if the content is the same). I'm putting "issue" between quotation marks as it is very very rare to cause any actual scanning issues, it just causes confusion. I will, however, close this issue because the OP reported the card did work at the store and I think the existing #939 describes the issue more clearly and is thus easier to track. |
Actually wait, I wanted to keep this open not for the QR code thing but for the fact that Catima puts https://scan.joyn.be/... at the start of the barcode while that's not on the actual card. It's correct behaviour on Catima's side, but I want to track the stores that put another code on the card than actually in the image for if we ever start building some kind of database of stores. The QR code thing though is more relevant to issue #939 :) |
I scanned a card with a QR-code in the app Catima.
When I view the QR-code in the app for this card, the QR-code is different from the original.
What is wrong ?
The text was updated successfully, but these errors were encountered: