Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return type option for TLS/CLS/FLS commands #31

Closed
wants to merge 2 commits into from
Closed

Add return type option for TLS/CLS/FLS commands #31

wants to merge 2 commits into from

Conversation

eol-account
Copy link

Requested in #14

Adds the config option <response-format> to <media-server>. Takes SDL (default), JSON, or XML

@Julusian
Copy link
Member

Julusian commented Sep 4, 2023

I am currently thinking that we shouldnt include this, as this will easily cause confusion and break existing clients, and when relayed back to any clients over amcp does break the format that amcp is expected to be in.

Personally, I think a better approach is for the clients that want this enhanced data to connect directly to the scanner over http. It does add some complexity for deployment/firewalls, but it will slightly reduce the load on casparcg and allow for more advanced things to be done between the scanner and any clients.

Or I wouldnt be opposed to this being done as a parameter passed through amcp, to specify the encoding. If someone wants to rework this to do that and open a new pr, that could be accepted

@Julusian Julusian closed this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants