Skip to content

Commit

Permalink
Fix tests for Python 3.5
Browse files Browse the repository at this point in the history
  • Loading branch information
Jesus89 committed Mar 26, 2021
1 parent 11603b0 commit ed013bc
Showing 1 changed file with 18 additions and 7 deletions.
25 changes: 18 additions & 7 deletions tests/unit/data/client/test_sql_client.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
"""Unit tests for cartoframes.client.SQLClient"""

from collections import OrderedDict

from cartoframes.auth import Credentials
from cartoframes.io.managers.context_manager import ContextManager
from cartoframes.data.clients import SQLClient
Expand Down Expand Up @@ -186,8 +188,10 @@ def test_create_table_no_cartodbfy(self, mocker):
"""client.SQLClient.create_table"""
mocker.patch.object(ContextManager, 'get_schema')
mock = mocker.patch.object(ContextManager, 'execute_long_running_query')
SQLClient(self.credentials).create_table(
'table_name', {'id': 'INT', 'name': 'TEXT'}, cartodbfy=False)
columns = OrderedDict()
columns['id'] = 'INT'
columns['name'] = 'TEXT'
SQLClient(self.credentials).create_table('table_name', columns, cartodbfy=False)

mock.assert_called_once_with('''
BEGIN;
Expand All @@ -201,8 +205,10 @@ def test_create_table_cartodbfy_org_user(self, mocker):
"""client.SQLClient.create_table cartodbfy: organization user"""
mocker.patch.object(ContextManager, 'get_schema', return_value='user_name')
mock = mocker.patch.object(ContextManager, 'execute_long_running_query')
SQLClient(self.credentials).create_table(
'table_name', {'id': 'INT', 'name': 'TEXT'}, if_exists='replace')
columns = OrderedDict()
columns['id'] = 'INT'
columns['name'] = 'TEXT'
SQLClient(self.credentials).create_table('table_name', columns, if_exists='replace')

mock.assert_called_once_with('''
BEGIN;
Expand All @@ -216,8 +222,10 @@ def test_create_table_cartodbfy_public_user(self, mocker):
"""client.SQLClient.create_table cartodbfy: public user"""
mocker.patch.object(ContextManager, 'get_schema', return_value='public')
mock = mocker.patch.object(ContextManager, 'execute_long_running_query')
SQLClient(self.credentials).create_table(
'table_name', {'id': 'INT', 'name': 'TEXT'}, if_exists='fail')
columns = OrderedDict()
columns['id'] = 'INT'
columns['name'] = 'TEXT'
SQLClient(self.credentials).create_table('table_name', columns, if_exists='fail')

mock.assert_called_once_with('''
BEGIN;
Expand All @@ -230,7 +238,10 @@ def test_create_table_cartodbfy_public_user(self, mocker):
def test_insert_table(self, mocker):
"""client.SQLClient.insert_table"""
mock = mocker.patch.object(ContextManager, 'execute_long_running_query')
SQLClient(self.credentials).insert_table('table_name', {'id': [0, 1], 'name': ['a', 'b']})
values = OrderedDict()
values['id'] = [0, 1]
values['name'] = ['a', 'b']
SQLClient(self.credentials).insert_table('table_name', values)

mock.assert_called_once_with('''
INSERT INTO table_name (id,name) VALUES (0,'a'),(1,'b');
Expand Down

0 comments on commit ed013bc

Please sign in to comment.