Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable startupProbe in some containers #508

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −5
Draft

Enable startupProbe in some containers #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion chart/templates/import-api/deployment.yaml
View file
Original file line number Diff line number Diff line change
@@ -173,8 +173,11 @@ spec:
{{- if .Values.importApi.startupProbe.enabled }}
startupProbe: {{- include "common.tplvalues.render" (dict "value" (omit .Values.importApi.startupProbe "enabled") "context" $) | nindent 12 }}
httpGet:
path: /
path: /health
port: http
httpHeaders:
- name: Carto-Monitoring
value: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be a string to work 😄

{{- else if .Values.importApi.customStartupProbe }}
startupProbe: {{- include "common.tplvalues.render" (dict "value" .Values.importApi.customStartupProbe "context" $) | nindent 12 }}
{{- end }}
5 changes: 4 additions & 1 deletion chart/templates/maps-api/deployment.yaml
View file
Original file line number Diff line number Diff line change
@@ -171,8 +171,11 @@ spec:
{{- if .Values.mapsApi.startupProbe.enabled }}
startupProbe: {{- include "common.tplvalues.render" (dict "value" (omit .Values.mapsApi.startupProbe "enabled") "context" $) | nindent 12 }}
httpGet:
path: /
path: /health
port: http
httpHeaders:
- name: Carto-Monitoring
value: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same ⬆️

{{- else if .Values.mapsApi.customStartupProbe }}
startupProbe: {{- include "common.tplvalues.render" (dict "value" .Values.mapsApi.customStartupProbe "context" $) | nindent 12 }}
{{- end }}
3 changes: 3 additions & 0 deletions chart/templates/workspace-api/deployment.yaml
View file
Original file line number Diff line number Diff line change
@@ -255,6 +255,9 @@ spec:
httpGet:
path: /health
port: http
httpHeaders:
- name: Carto-Monitoring
value: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same ⬆️

{{- else if .Values.workspaceApi.customStartupProbe }}
startupProbe: {{- include "common.tplvalues.render" (dict "value" .Values.workspaceApi.customStartupProbe "context" $) | nindent 12 }}
{{- end }}
6 changes: 3 additions & 3 deletions chart/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -824,7 +824,7 @@ importApi:
## @param importApi.startupProbe.successThreshold Success threshold for startupProbe
##
startupProbe:
enabled: false
enabled: true
initialDelaySeconds: 10
periodSeconds: 30
timeoutSeconds: 5
@@ -1687,7 +1687,7 @@ mapsApi:
## @param mapsApi.startupProbe.successThreshold Success threshold for startupProbe
##
startupProbe:
enabled: false
enabled: true
initialDelaySeconds: 10
periodSeconds: 30
timeoutSeconds: 5
@@ -3672,7 +3672,7 @@ workspaceApi:
## @param workspaceApi.startupProbe.successThreshold Success threshold for startupProbe
##
startupProbe:
enabled: false
enabled: true
initialDelaySeconds: 10
periodSeconds: 30
timeoutSeconds: 5