fix(bq,sf,rs,pg): drop schemas when dedicateds gets released #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdelacruzb
added
dedicated_bigquery
|
Dedicated dedicated_485_carto environment deployed in Postgres host aurora-postgres-shared-serverless-2413.cluster-chd0o1w0ghry.us-east-1.rds.amazonaws.com and carto_dev_data database |
|
Dedicated dedicated_485_carto environment deployed in Snowflake database sxa81489.us-east-1. |
|
Dedicated dedicated_485_carto environment deployed in Bigquery project carto-dev-data |
vdelacruzb
removed
the
dedicated_snowflake
|
Dedicated environment removed |
|
Dedicated carto environment deployed in Redshift host redshift-serverless-shared.515242991920.us-east-1.redshift-serverless.amazonaws.com and carto_dev_data database |
vdelacruzb
removed
the
dedicated_bigquery
|
Dedicated environment removed |
vdelacruzb
removed
dedicated_postgres
|
Dedicated environment removed |
1 similar comment
|
Dedicated environment removed |
vdelacruzb
added
dedicated_redshift
|
Dedicated environment removed |
Jesus89
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut
I've noticed that with my changes in: #466 when dedicateds were removed, only the functions were removed instead of the whole schema.
I've restored
make removeas it was before and addedmake remove-functionsto only removed functions for development purposes.Also have found bug in redshift dedicateds.
Type of change
Acceptance
Tested to run in the different providers/modules folder:
Also tried to create and remove dedicated and see how the schemas gets removed.