feat(bq,sf,rs,pg|quadbin): add function QUADBIN_DISTANCE #457

vdelacruzb · 2023-12-27T15:25:44Z

Description

Shortcut

Story: https://app.shortcut.com/cartoteam/story/318681/missing-quadbin-distance-in-at
Autolink: [sc-318681]

Type of change

Feature

Acceptance

-- BQ 
SELECT `cartodb-data-engineering-team`.vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207251884775047167);
-- 0
SELECT `cartodb-data-engineering-team`.vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207128739472736255);
-- 1
SELECT `cartodb-data-engineering-team`.vdelacruz_carto.QUADBIN_DISTANCE(`carto-un`.carto.QUADBIN_FROMZXY(5,1,5), `carto-un`.carto.QUADBIN_FROMZXY(5,2,7))
-- 2
SELECT `cartodb-data-engineering-team`.vdelacruz_carto.QUADBIN_DISTANCE(`carto-un`.carto.QUADBIN_FROMZXY(5,1,5), `carto-un`.carto.QUADBIN_FROMZXY(6,2,7))
-- NULL
SELECT `cartodb-data-engineering-team`.vdelacruz_carto.QUADBIN_DISTANCE(NULL, 5207128739472736255);
-- NULL
SELECT `cartodb-data-engineering-team`.vdelacruz_carto.QUADBIN_DISTANCE(5207128739472736255, NULL);
-- NULL

-- SF
SELECT CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207251884775047167);
-- 0
SELECT CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207128739472736255);
-- 1
SELECT CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_DISTANCE(CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_FROMZXY(5,1,5), CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_FROMZXY(5,2,7));
-- 2
SELECT CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_DISTANCE(CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_FROMZXY(5,1,5), CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_FROMZXY(6,2,7));
-- NULL
SELECT CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_DISTANCE(NULL, 5207128739472736255);
-- NULL
SELECT CARTO_DATA_ENGINEERING_TEAM.vdelacruz_carto.QUADBIN_DISTANCE(5207128739472736255, NULL);

-- RS
SELECT vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207251884775047167);
-- 0
SELECT vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207128739472736255);
-- 1
SELECT vdelacruz_carto.QUADBIN_DISTANCE(vdelacruz_carto.QUADBIN_FROMZXY(5,1,5), vdelacruz_carto.QUADBIN_FROMZXY(5,2,7));
-- 2
SELECT vdelacruz_carto.QUADBIN_DISTANCE(vdelacruz_carto.QUADBIN_FROMZXY(5,1,5), vdelacruz_carto.QUADBIN_FROMZXY(6,2,7));
-- NULL
SELECT vdelacruz_carto.QUADBIN_DISTANCE(NULL, 5207128739472736255);
-- NULL
SELECT vdelacruz_carto.QUADBIN_DISTANCE(5207128739472736255, NULL);
-- NULL

-- PG
SELECT vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207251884775047167);
-- 0
SELECT vdelacruz_carto.QUADBIN_DISTANCE(5207251884775047167, 5207128739472736255);
-- 1
SELECT vdelacruz_carto.QUADBIN_DISTANCE(vdelacruz_carto.QUADBIN_FROMZXY(5,1,5), vdelacruz_carto.QUADBIN_FROMZXY(5,2,7));
-- 2
SELECT vdelacruz_carto.QUADBIN_DISTANCE(vdelacruz_carto.QUADBIN_FROMZXY(5,1,5), vdelacruz_carto.QUADBIN_FROMZXY(6,2,7));
-- NULL
SELECT vdelacruz_carto.QUADBIN_DISTANCE(NULL, 5207128739472736255);
-- NULL
SELECT vdelacruz_carto.QUADBIN_DISTANCE(5207128739472736255, NULL);
-- NULL

shortcut-integration · 2023-12-27T15:25:47Z

This pull request has been linked to Shortcut Story #318681: Missing QUADBIN_DISTANCE in AT.

jgoizueta · 2023-12-28T12:47:45Z

clouds/bigquery/modules/doc/quadbin/QUADBIN_DISTANCE.md

+
+**Description**
+
+Returns the **Chebyshev distance** between two quadbin indexes. Returns `null` on invalid inputs.


perhaps "the Chebyshev distance in quadbin cells between two quadbin indexes" ? but I'm not sure, it might be confusing... the Chebyshev distance in number of quadbin cells between two quadbin indexes" ?? I'm not sure yet.

We could also add a comment about both indices needing to be of the same resultion.

On second thought, if the reader understands what Chebyshev distance is (or they have looked it up), they probably have figured out what this that, so we can leave that sentence as it. But I would add:

The origin and destination indices must have the same resolution. Otherwise NULL will be returned.

I'll also had the link to wikipedia as we do in here:
https://github.com/CartoDB/analytics-toolbox-core/blob/bug/sc-318681/missing-quadbin-distance-in-at/clouds/redshift/modules/doc/quadbin/QUADBIN_KRING_DISTANCES.md#L36

jgoizueta · 2023-12-28T12:51:15Z

clouds/postgres/modules/doc/quadbin/QUADBIN_DISTANCE.md

+**Description**
+
+Returns the **Chebyshev distance** between two quadbin indexes. Returns `null` on invalid inputs.
+


same as BQ:

The origin and destination indices must have the same resolution. Otherwise NULL will be returned.

jgoizueta · 2023-12-28T12:53:06Z

clouds/postgres/modules/sql/quadbin/QUADBIN_DISTANCE.sql

+                    NULL
+                ELSE
+                    GREATEST(
+                        ABS((destination_coords->>'x')::DOUBLE PRECISION - (origin_coords->>'x')::DOUBLE PRECISION),


minor thing: I guess we could cast the coordinates to to BIGINT as well, right?

Actually the DOUBLE PRECISION was intended here. As I took the approach used in QUADBIN_CENTER but BIGINT makes more sense, will add it.

jgoizueta · 2023-12-28T12:53:21Z

clouds/redshift/modules/doc/quadbin/QUADBIN_DISTANCE.md

+**Description**
+
+Returns the **Chebyshev distance** between two quadbin indexes. Returns `null` on invalid inputs.
+


same as BQ:

The origin and destination indices must have the same resolution. Otherwise NULL will be returned.

jgoizueta · 2023-12-28T13:01:09Z

clouds/snowflake/modules/doc/quadbin/QUADBIN_DISTANCE.md

+**Description**
+
+Returns the **Chebyshev distance** between two quadbin indexes. Returns `null` on invalid inputs.
+


same as BQ:

The origin and destination indices must have the same resolution. Otherwise NULL will be returned.

jgoizueta

LGTM

Jesus89 · 2024-01-10T19:39:50Z

clouds/bigquery/modules/doc/quadbin/QUADBIN_DISTANCE.md

+
+**Return type**
+
+`GEOGRAPHY`


Jesus89 · 2024-01-10T19:40:32Z

clouds/postgres/modules/doc/quadbin/QUADBIN_DISTANCE.md

+
+**Return type**
+
+`GEOGRAPHY`


Jesus89 · 2024-01-10T19:40:49Z

clouds/redshift/modules/doc/quadbin/QUADBIN_DISTANCE.md

+
+**Return type**
+
+`GEOGRAPHY`


Jesus89 · 2024-01-10T19:41:25Z

clouds/snowflake/modules/doc/quadbin/QUADBIN_DISTANCE.md

+
+**Return type**
+
+`GEOGRAPHY`


vdelacruzb added 2 commits December 27, 2023 16:22

add quadbin distance to bq

1c44012

lint BQ

7d5e554

vdelacruzb added 5 commits December 27, 2023 16:56

add QUADBIN_DISTANCE to SF

5d472cd

add QUADBIN_DISTANCE to RS

3017ba9

lint tests RS

a1ed1b3

add QUADBIN_DISTANCE to PG

dfc3bf0

fix deploy in RS

0f7c40d

vdelacruzb requested a review from jgoizueta December 27, 2023 19:18

jgoizueta reviewed Dec 28, 2023

View reviewed changes

jgoizueta approved these changes Dec 28, 2023

View reviewed changes

apply suggested changes

8c5b0c2

vdelacruzb merged commit e5ab01b into main Dec 28, 2023
20 checks passed

vdelacruzb deleted the bug/sc-318681/missing-quadbin-distance-in-at branch December 28, 2023 14:06

Jesus89 reviewed Jan 10, 2024

View reviewed changes

clouds/bigquery/modules/doc/quadbin/QUADBIN_DISTANCE.md

**Return type**

`GEOGRAPHY`

Copy link

Member

Jesus89 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INT64

Jesus89 reviewed Jan 10, 2024

View reviewed changes

clouds/postgres/modules/doc/quadbin/QUADBIN_DISTANCE.md

**Return type**

`GEOGRAPHY`

Copy link

Member

Jesus89 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIGINT

Jesus89 reviewed Jan 10, 2024

View reviewed changes

clouds/redshift/modules/doc/quadbin/QUADBIN_DISTANCE.md

**Return type**

`GEOGRAPHY`

Copy link

Member

Jesus89 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIGINT

Jesus89 reviewed Jan 10, 2024

View reviewed changes

clouds/snowflake/modules/doc/quadbin/QUADBIN_DISTANCE.md

**Return type**

`GEOGRAPHY`

Copy link

Member

Jesus89 Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIGINT

vdelacruzb mentioned this pull request Jan 17, 2024

release: 2024-01-17 #471

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(bq,sf,rs,pg|quadbin): add function QUADBIN_DISTANCE #457

feat(bq,sf,rs,pg|quadbin): add function QUADBIN_DISTANCE #457

vdelacruzb commented Dec 27, 2023 •

edited

Loading

shortcut-integration bot commented Dec 27, 2023

jgoizueta Dec 28, 2023

jgoizueta Dec 28, 2023

vdelacruzb Dec 28, 2023

jgoizueta Dec 28, 2023

jgoizueta Dec 28, 2023

vdelacruzb Dec 28, 2023

jgoizueta Dec 28, 2023

jgoizueta Dec 28, 2023

jgoizueta left a comment

Jesus89 Jan 10, 2024

Jesus89 Jan 10, 2024

Jesus89 Jan 10, 2024

Jesus89 Jan 10, 2024


		Description

		Returns the Chebyshev distance between two quadbin indexes. Returns `null` on invalid inputs.

feat(bq,sf,rs,pg|quadbin): add function QUADBIN_DISTANCE #457

feat(bq,sf,rs,pg|quadbin): add function QUADBIN_DISTANCE #457

Conversation

vdelacruzb commented Dec 27, 2023 • edited Loading

Description

Type of change

Acceptance

shortcut-integration bot commented Dec 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jgoizueta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vdelacruzb commented Dec 27, 2023 •

edited

Loading