PAC195X #51
Merged
PAC195X #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use of it where applicable.
…ter was 0xFE instead of 0xFF.
…2 channels. Also fixed bug in block write DCMD selection.
… after each read, a refresh command must be sent to get new data.
…o not seem to equal vbus * vsense.
…Vpower measurements to explanation in the datasheet: product is taken using signed numbers for vbus and vsense and chip uses more bits than the reported vbus and vsense values.
…need to fix this for other block reads as well. This correctly yields the bus values now.
… sure our Rsense resistors are 0 ohms, so I'm keeping full scale current at 100mV. Not sure how much current to look for.
…wer during time of testing. Must test again with battery connected.
…urements (i.e. it matters which sensor took them).
|
Co-PR of CarletonURocketry/packager#71 in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a driver for the PAC195X family of current sensors. The PAC1952-2 also has a collector thread implementation (because the MCU board contains that variant).
This PR also inter-ops with the new voltage encoding for telemetry. It includes a change that allows sensor data types (
TAG_*) to implicitly be associated with a numerical ID. This is useful for sensors that measure localized data.For example, right now it doesn't matter which sensor temperature is measured on, because the temperature being sensed should be roughly consistent across all sensors. However, the voltage sensor measures voltages on a specific trace. It is important to track which measurements are connected with which trace, or it will be difficult to detect voltage changes and match up the measurements with certain components/traces.