Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place anchor based on XY screen coordinates and update ARCore SDK to 1.35.0 #162

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

dnkoulouris
Copy link
Contributor

@dnkoulouris dnkoulouris commented Dec 13, 2022

A pull request that adds functionality to place an anchor at the X,Y coordinates of the screen.

I also did some updates to ARCore libraries, in order to have the most recent available versions.

Just call:

// Places anchor in given 2D coordinates (starting from the top-left side of the screen)
placeBasedOnScreenCoordinates(double x, double y)

and an Anchor will be placed at the exact spot

@dnkoulouris dnkoulouris changed the title Calculate distances between two anchors, anchor and device and two vectors Place anchor based on XYZ screen coordinates Dec 13, 2022
@dnkoulouris dnkoulouris changed the title Place anchor based on XYZ screen coordinates Place anchor based on XY screen coordinates Dec 13, 2022
@dnkoulouris dnkoulouris changed the title Place anchor based on XY screen coordinates Place anchor based on XY screen coordinates and update ARCore SDK to 1.35.0 Dec 19, 2022
@CariusLars
Copy link
Owner

Hey @dnkoulouris, thanks for this PR! Have you tested to make sure all functionalities of the example app work on both Android and iOS?

If this is the case, could you please:

  1. Merge in main of this repo to resolve the merge conflict
  2. Write an entry for your feature and fixes into changelog.md
  3. Set a new minor version number in the readme and the pubspec.yaml

Happy to merge after that :)

@dnkoulouris
Copy link
Contributor Author

Just performed the aforementioned changes. I also changed the cloud anchor setup file, indicating the requirement of enabling the new ARCore API (The old one, Cloud Anchors API, is deprecated) from the Google Cloud Console.

@JeroenMoonen
Copy link

JeroenMoonen commented Jan 18, 2023

Nice contrib @dnkoulouris, waiting for this release!

Copy link

@tonyhart7 tonyhart7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vicajilau
Copy link

Amazing job @dnkoulouris !! Could you review this @CariusLars ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants