Fixed clip planes lagging behind when parented to a bone on a model part

lua/pac3/core/client/parts/bone.lua

@@ -1,4 +1,4 @@
 local NULL = NULL
 local pairs = pairs
 local Matrix = Matrix
 local vector_origin = vector_origin
@@ -12,13 +12,13 @@
 local BUILDER, PART = pac.PartTemplate("base_movable")
 
 PART.FriendlyName = "bone"
 PART.ClassName = "bone3"
 PART.Groups = {'entity', 'model'}
 PART.Icon = 'icon16/connect.png'
 PART.is_bone_part = true
 
 BUILDER:StartStorableVars()
 	BUILDER:SetPropertyGroup("generic")
 		BUILDER:PropertyOrder("Name")
 		BUILDER:PropertyOrder("Hide")
 		BUILDER:PropertyOrder("ParentName")
@@ -36,7 +36,7 @@
 		BUILDER:PropertyOrder("Angles")
 		BUILDER:PropertyOrder("EyeAngles")
 		BUILDER:GetSet("Size", 1, {editor_sensitivity = 0.25})
 		BUILDER:GetSet("Scale", Vector(1,1,1), {editor_sensitivity = 0.25})
 		BUILDER:PropertyOrder("PositionOffset")
 		BUILDER:PropertyOrder("AngleOffset")
 
@@ -290,12 +290,12 @@
 	if not self.bone_index then return ent:GetPos(), ent:GetAngles() end
 
 	local m = ent:GetBoneMatrix(self.bone_index)
-	if not m then return ent:GetPos(), ent:GetAngles() end
 
-	local pos = m:GetTranslation()
-	local ang = m:GetAngles()
-
-	return pos, ang
+	if m then
+		return m:GetTranslation(), m:GetAngles()
+	else
+		return ent:GetPos(), ent:GetAngles()
+	end
 end
 
 function PART:GetBoneMatrix()
@@ -306,12 +306,15 @@
 
 pac.AddHook("OnEntityCreated", "hide_mesh_no_crash", function(ent)
 	local ply = ent:GetRagdollOwner()
+
 	if ply:IsPlayer() and ply.pac_inf_scale then
 		for i = 0, ply:GetBoneCount() - 1 do
 			local scale = ply:GetManipulateBoneScale(i)
+
 			if scale == inf_scale then
-				scale = Vector(0,0,0)
+				scale = vector_origin
 			end
+
 			ply:ManipulateBoneScale(i, scale)
 		end
 	end

lua/pac3/core/client/parts/clip.lua

@@ -1,13 +1,13 @@
 local render_EnableClipping = render.EnableClipping
 local render_PushCustomClipPlane = render.PushCustomClipPlane
 local LocalToWorld = LocalToWorld
 local IsEntity = IsEntity
 
 local BUILDER, PART = pac.PartTemplate("base_drawable")
 
 PART.FriendlyName = "clip"
 PART.ClassName = "clip2"
 PART.Groups = {'model', 'modifiers'}
 PART.Icon = 'icon16/cut.png'
 
 function PART:OnParent(part)
@@ -40,6 +40,16 @@
 	function PART:PreOnDraw()
 		bclip = render_EnableClipping(true)
 
+		-- this fixes clip planes lagging behind when parented to a bone on a model part
+		local owner = self:GetParentOwner()
+		if owner:IsValid() and not owner.pac_clip_bonessetup and owner.PACPart then
+			-- in case there are multiple clips on one model part, only the first one needs to call SetupBones
+			self.pac_clip_owner = owner
+			owner.pac_clip_bonessetup = true
+
+			pac.SetupBones(owner)
+		end
+
 		local pos, ang = LocalToWorld(self.Position + self.PositionOffset, self:CalcAngles(self.Angles + self.AngleOffset), self:GetBonePosition())
 		local normal = ang:Forward()
 
@@ -49,6 +59,11 @@
 	local render_PopCustomClipPlane = render.PopCustomClipPlane
 
 	function PART:PostOnDraw()
+		if self.pac_clip_owner then
+			self.pac_clip_owner.pac_clip_bonessetup = nil
+			self.pac_clip_owner = nil
+		end
+
 		render_PopCustomClipPlane()
 
 		render_EnableClipping(bclip)