Reverse reaction (super-elastic) electron collision reaction

[BangShiuh]

Changes proposed in this pull request

The reverse reaction rate of electron collision reaction is added. The reverse rate is calculated super-elastic formula. In the test, a reversible elastic reaction is used for testing purpose only. The reverse rate is the same as the forward rate if the threshold energy is zero.

• Use commits from @speth for modification of the reverse rate.
• Make electron collision plasma reaction (ECPR) reversible.
• Add test for ECPR.
• I will add the example later - while working on this I found Electron mole fraction increases to one without a reaction #1856

If applicable, fill in the issue number this pull request is fixing

Cantera/enhancements#192

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

• The pull request includes a clear description of this code change
• Commit messages have short titles and reference relevant issues
• Build passes (scons build & scons test) and unit tests address code coverage
• Style & formatting of contributed code follows contributing guidelines
• The pull request is ready for review

[codecov]

Codecov Report

Attention: Patch coverage is 83.07692% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.13%. Comparing base (932f899) to head (6fdf863).
Report is 23 commits behind head on main.

Files with missing lines	Patch %	Lines
src/kinetics/ElectronCollisionPlasmaRate.cpp	73.07%	3 Missing and 4 partials ⚠️
src/kinetics/BulkKinetics.cpp	89.47%	0 Missing and 2 partials ⚠️
src/kinetics/InterfaceKinetics.cpp	84.61%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1854   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files         443      443           
  Lines       55400    55423   +23     
  Branches     9107     9114    +7     
=======================================
+ Hits        41069    41089   +20     
  Misses      11241    11241           
- Partials     3090     3093    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[speth]

Thanks, @BangShiuh, I think this looks good, and seems like a reasonable time to merge in my implementation of ReactionRate.modifyRateConstants. While this had originally been done with electrochemical rate parameterizations in mind, I'm glad to see that it's general enough to be useful here as well. I have just a couple of minor cleanup suggestions.

[BangShiuh]

@speth Thank you for the code review. The issues have been fixed.

[speth]

@ischoegl - Since this incorporates an extension of the ReactionRate / MultiRate interface that I wrote a while back, do you want to look this over and approve? This was written with the intention of it being used to generalize electrochemical rate handling (which has previously been discussed in Cantera/enhancements#38 and Cantera/enhancements#44, though not this specific implementation).

[ischoegl]

@speth ... sure - I looked over the three commits and only found one virtual that is no longer needed.

[ischoegl]

I believe this won't need to be virtual any longer, correct?

[speth]

Correct, and it should be const as well.