Complete Tests for Kinetics Class for the Matlab Toolbox #1665
Conversation
ssun30
force-pushed
the
matlab_patches
branch
from
8a95e99 to
ecc6173
Compare
|
@ssun30 and @rwest ... what are the current plans on this PR and Cantera/enhancements#177? With the old MATLAB toolbox removed, the next Cantera version will only provide for the experimental toolbox. |
Hi Ingmar, finishing the test suite is back on our to-do list and we were aiming to complete it by the end of the month. There is a slight delay so maybe the first week of July we shall have all the unit tests ready. |
ssun30
force-pushed
the
matlab_patches
branch
from
2cff437 to
a48e499
Compare
ssun30
force-pushed
the
matlab_patches
branch
from
4ded039 to
9f1e42b
Compare
Previously the buffer length does not account for the null terminator, which causes the string returned from Clib to miss the last character. The correct error code is also implemented. The previous code will incorrectly throw an exception when the string is a single character.
into test class setup and teardown
ssun30
force-pushed
the
matlab_patches
branch
from
8c98850 to
3acff45
Compare
|
After a year of hiatus this PR is finally ready for review. Thanks to support from Mathworks the plan to make the Matlab toolbox official is back on track. |
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Updates to Cantera/enhancements#177
If applicable, provide an example illustrating new features this pull request is introducing
Added tests for rates of progress, rate constants, species rates, and thermodynamic values.
Checklist
scons build&scons test) and unit tests address code coverage