Few lines added for Windows configuration #95
Conversation
|
In my opinion, The mention |
|
|
||
| ### Windows | ||
|
|
||
| - [Docker and Docker Compose](https://docs.docker.com/engine/installation/windows/) | ||
| - Docker needs Hyper-V activated and purpose to activate it itself (restart needed). Beware : activating Hyper-V disables any other virtualisation softwares. |
There was a problem hiding this comment.
Should be deleted, this is a Docker prerequisite.
There was a problem hiding this comment.
not a Docker prerequisite if you don't use Docker for Windows, but indeed 99.99% of docker users will use it, so the whole Requirements section seems overkill to me (or explicitly mention that we assume they will use Docker for Windows for Windows and Docker for Mac for Mac)... The Linux section remains useful only to tell users to install docker-compose which is not a default when installing docker on linux
docker/README.md
Outdated
| @@ -39,6 +40,10 @@ Miaou development environment using Docker | |||
|
|
|||
| 4. Prebuild Miaou: | |||
|
|
|||
| Windows configuration : | |||
| - When cloning miaou repository, make sure you keep LF and not CRLF or it will generate end of files errors during the prebuild | |||
| - Open PowerShell, you must be at the root directory of Miaou which contains the DockerFile | |||
There was a problem hiding this comment.
Should be moved in a common section (not mentionning PowerShell, but just a shell).
docker/README.md
Outdated
| @@ -8,6 +8,7 @@ Miaou development environment using Docker | |||
| ### Linux | |||
|
|
|||
| - [Docker and Docker Compose](https://docs.docker.com/engine/installation/linux/) | |||
| - Docker needs Hyper-V activated and purpose to activate it itself (restart needed). Beware : activating Hyper-V disables any other virtualisation softwares. | |||
There was a problem hiding this comment.
AFAIK, Hyper-V has nothing to do with Linux, this is Windows only related, I don't think you want to put that in this section
Besides, with "Docker for Windows/Mac“, this is now trivial to use docker in "any" environment. So I don't think the whole Requirements section is still a good thing to have and maintain
No description provided.