Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSSQL testcontainer to 2019-CU27-ubuntu-20.04 version #730

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

goldmedal
Copy link
Contributor

Description

The latest version of the MSSQL container will cause the timeout error for ibis CI. Fix the version to 2019-CU27-ubuntu-20.04 for stable testing.

Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @goldmedal.

@grieve54706 grieve54706 merged commit 8325e40 into main Aug 6, 2024
4 checks passed
@grieve54706 grieve54706 deleted the chore/fix-mssql-test-container-version branch August 6, 2024 02:56
@grieve54706
Copy link
Contributor

Microsoft changes the tool folder name. Testcontainer could not use the right path to check database status by mssql tool.

Relate microsoft/mssql-docker#892 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants