Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2529-More corrections for add layer and the config API #2530

Conversation

ychoquet
Copy link
Member

@ychoquet ychoquet commented Sep 30, 2024

Description

QA done on hte add layer and the config API revealed some issues. This PR proposes corrections to be applied to the code.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using the add-layer.html template.

Deploy URL: https://ychoquet.github.io/GeoView

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@ychoquet ychoquet force-pushed the 2529-More_corrections_for_add_layer_and_the_config_api branch 2 times, most recently from 41ba04d to c84e890 Compare October 1, 2024 00:51
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 19 files at r1, all commit messages.
Reviewable status: 18 of 19 files reviewed, all discussions resolved

@ychoquet ychoquet force-pushed the 2529-More_corrections_for_add_layer_and_the_config_api branch from c84e890 to d840ec8 Compare October 2, 2024 17:24
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)

@ychoquet ychoquet force-pushed the 2529-More_corrections_for_add_layer_and_the_config_api branch from d840ec8 to 30e0475 Compare October 8, 2024 16:00
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ychoquet)

@jolevesq jolevesq merged commit d07aff8 into Canadian-Geospatial-Platform:develop Oct 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants