Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

41 remove-link #43

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Pewillia
Copy link
Collaborator

@Pewillia Pewillia commented Oct 4, 2024

Description

remove-link

Remove link to demo at top of map at the left, using an arrow and on the right at the top ,as well a link to the repositories page

Fixes # (41) remove-link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? yes

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

deploy url: https://pewillia.github.io/geoview-demo/

Checklist:

  • [ X] I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [X ] My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Pewillia Pewillia requested a review from jolevesq October 4, 2024 19:35
@Pewillia Pewillia self-assigned this Oct 4, 2024
Copy link
Member

@cphelefu cphelefu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good; will likely have to reverse it once we move to multi-pages setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants