Skip to content

Commit

Permalink
Merge pull request #69 from Alex-NRCan/fix-min-height
Browse files Browse the repository at this point in the history
fix(style-height) No more internal min-height of 400px
  • Loading branch information
jolevesq authored Feb 28, 2024
2 parents 13db37a + 733cacd commit e549f6b
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion src/chart-style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
export const sxClasses = {
mainContainer: {
width: '100%',
minHeight: '400px',
},
mainGeoChartContainer: {},
header: {
Expand Down
2 changes: 1 addition & 1 deletion src/chart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ export function GeoChart<
GeoChartDatasource | undefined,
React.Dispatch<GeoChartDatasource | undefined>
];
const [action, setAction] = useState(parentAction) as [GeoChartAction, React.Dispatch<GeoChartAction>];
const [redraw, setRedraw] = useState(parentAction?.shouldRedraw) as [boolean | undefined, React.Dispatch<boolean | undefined>];
const [isLoadingDatasource, setIsLoadingDatasource] = useState(parentLoadingDatasource) as [boolean, React.Dispatch<boolean>];

// Inner component states unrelated to the parent component
const [action, setAction] = useState() as [GeoChartAction, React.Dispatch<GeoChartAction>];
const [datasetRegistry, setDatasetRegistry] = useState({}) as [GeoChartSelectedDataset, React.Dispatch<GeoChartSelectedDataset>];
const [datasRegistry, setDatasRegistry] = useState({}) as [GeoChartSelectedDataset, React.Dispatch<GeoChartSelectedDataset>];
const [filteredRecords, setFilteredRecords] = useState() as [TypeJsonObject[] | undefined, React.Dispatch<TypeJsonObject[] | undefined>];
Expand Down

0 comments on commit e549f6b

Please sign in to comment.