Skip to content

Commit

Permalink
Aperture: Switch to coil3
Browse files Browse the repository at this point in the history
Removes unused okhttp dep

Change-Id: Ib1e68cd27b6a25476560425bf28a3133ce205bc7
  • Loading branch information
luca020400 committed Jan 2, 2025
1 parent 6288db3 commit 2e066d2
Show file tree
Hide file tree
Showing 24 changed files with 66 additions and 67 deletions.
8 changes: 5 additions & 3 deletions app/Android.bp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// SPDX-FileCopyrightText: 2022-2024 The LineageOS Project
// SPDX-FileCopyrightText: 2022-2025 The LineageOS Project
// SPDX-License-Identifier: Apache-2.0
//

Expand Down Expand Up @@ -48,8 +48,10 @@ android_app {
"androidx.preference_preference",
"com.google.android.material_material",
"Aperture_com.google.zxing_core",
"Aperture_io.coil-kt_coil",
"Aperture_io.coil-kt_coil-video",
"Aperture_io.coil-kt.coil3_coil",
"Aperture_io.coil-kt.coil3_coil-android",
"Aperture_io.coil-kt.coil3_coil-core-android",
"Aperture_io.coil-kt.coil3_coil-video",
"Aperture_io.github.zxing-cpp_android",
"kotlin-stdlib-jdk8",
],
Expand Down
6 changes: 3 additions & 3 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2022-2024 The LineageOS Project
* SPDX-FileCopyrightText: 2022-2025 The LineageOS Project
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -115,8 +115,8 @@ dependencies {
implementation("io.github.zxing-cpp:android:2.2.0")

// Coil
implementation("io.coil-kt:coil:2.4.0")
implementation("io.coil-kt:coil-video:2.4.0")
implementation("io.coil-kt.coil3:coil:3.0.4")
implementation("io.coil-kt.coil3:coil-video:3.0.4")
}

configure<GenerateBpPluginExtension> {
Expand Down
95 changes: 46 additions & 49 deletions app/libs/Android.bp
Original file line number Diff line number Diff line change
Expand Up @@ -619,181 +619,178 @@ java_library_static {
],
}

java_import {
name: "Aperture_com.squareup.okhttp3_okhttp-nodeps",
jars: ["com/squareup/okhttp3/okhttp/4.11.0/okhttp-4.11.0.jar"],
java_library_static {
name: "Aperture_com.squareup.okio_okio",
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
static_libs: [
"Aperture_com.squareup.okio_okio-jvm",
],
}

java_library_static {
name: "Aperture_com.squareup.okhttp3_okhttp",
java_import {
name: "Aperture_com.squareup.okio_okio-jvm-nodeps",
jars: ["com/squareup/okio/okio-jvm/3.9.1/okio-jvm-3.9.1.jar"],
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
static_libs: [
"Aperture_com.squareup.okhttp3_okhttp-nodeps",
"Aperture_com.squareup.okio_okio",
"kotlin-stdlib",
"kotlin-stdlib-jdk8",
],
}

java_library_static {
name: "Aperture_com.squareup.okio_okio",
name: "Aperture_com.squareup.okio_okio-jvm",
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
static_libs: [
"Aperture_com.squareup.okio_okio-jvm",
"Aperture_com.squareup.okio_okio-jvm-nodeps",
"kotlin-stdlib",
],
}

java_import {
name: "Aperture_com.squareup.okio_okio-jvm-nodeps",
jars: ["com/squareup/okio/okio-jvm/3.3.0/okio-jvm-3.3.0.jar"],
java_library_static {
name: "Aperture_io.coil-kt.coil3_coil",
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
static_libs: [
"Aperture_io.coil-kt.coil3_coil-android",
],
}

java_library_static {
name: "Aperture_com.squareup.okio_okio-jvm",
android_library_import {
name: "Aperture_io.coil-kt.coil3_coil-android-nodeps",
aars: ["io/coil-kt/coil3/coil-android/3.0.4/coil-release.aar"],
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
static_libs: [
"Aperture_com.squareup.okio_okio-jvm-nodeps",
"kotlin-stdlib-jdk8",
"Aperture_io.coil-kt.coil3_coil-core",
"kotlin-stdlib",
],
}

android_library_import {
name: "Aperture_io.coil-kt_coil-nodeps",
aars: ["io/coil-kt/coil/2.4.0/coil-2.4.0.aar"],
android_library {
name: "Aperture_io.coil-kt.coil3_coil-android",
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
manifest: "io/coil-kt/coil3/coil-android/3.0.4/AndroidManifest.xml",
static_libs: [
"Aperture_io.coil-kt_coil-base",
"kotlin-stdlib-jdk8",
"Aperture_io.coil-kt.coil3_coil-android-nodeps",
"Aperture_io.coil-kt.coil3_coil-core",
"kotlin-stdlib",
],
}

android_library {
name: "Aperture_io.coil-kt_coil",
java_library_static {
name: "Aperture_io.coil-kt.coil3_coil-core",
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
manifest: "io/coil-kt/coil/2.4.0/AndroidManifest.xml",
static_libs: [
"Aperture_io.coil-kt_coil-nodeps",
"Aperture_io.coil-kt_coil-base",
"kotlin-stdlib-jdk8",
"Aperture_io.coil-kt.coil3_coil-core-android",
],
}

android_library_import {
name: "Aperture_io.coil-kt_coil-base-nodeps",
aars: ["io/coil-kt/coil-base/2.4.0/coil-base-2.4.0.aar"],
name: "Aperture_io.coil-kt.coil3_coil-core-android-nodeps",
aars: ["io/coil-kt/coil3/coil-core-android/3.0.4/coil-core-release.aar"],
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
static_libs: [
"Aperture_com.squareup.okhttp3_okhttp",
"Aperture_com.squareup.okio_okio",
"androidx.annotation_annotation",
"androidx.appcompat_appcompat-resources",
"androidx.collection_collection",
"androidx.core_core-ktx",
"androidx.exifinterface_exifinterface",
"androidx.lifecycle_lifecycle-runtime",
"androidx.profileinstaller_profileinstaller",
"kotlin-stdlib",
"kotlinx-coroutines-android",
"kotlinx-coroutines-core",
],
}

android_library {
name: "Aperture_io.coil-kt_coil-base",
name: "Aperture_io.coil-kt.coil3_coil-core-android",
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
manifest: "io/coil-kt/coil-base/2.4.0/AndroidManifest.xml",
manifest: "io/coil-kt/coil3/coil-core-android/3.0.4/AndroidManifest.xml",
static_libs: [
"Aperture_io.coil-kt_coil-base-nodeps",
"Aperture_com.squareup.okhttp3_okhttp",
"Aperture_io.coil-kt.coil3_coil-core-android-nodeps",
"Aperture_com.squareup.okio_okio",
"androidx.annotation_annotation",
"androidx.appcompat_appcompat-resources",
"androidx.collection_collection",
"androidx.core_core-ktx",
"androidx.exifinterface_exifinterface",
"androidx.lifecycle_lifecycle-runtime",
"androidx.profileinstaller_profileinstaller",
"kotlin-stdlib",
"kotlinx-coroutines-android",
"kotlinx-coroutines-core",
],
}

android_library_import {
name: "Aperture_io.coil-kt_coil-video-nodeps",
aars: ["io/coil-kt/coil-video/2.4.0/coil-video-2.4.0.aar"],
name: "Aperture_io.coil-kt.coil3_coil-video-nodeps",
aars: ["io/coil-kt/coil3/coil-video/3.0.4/coil-video-3.0.4.aar"],
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
static_libs: [
"Aperture_io.coil-kt_coil-base",
"Aperture_io.coil-kt.coil3_coil-core",
"androidx.core_core-ktx",
"kotlin-stdlib-jdk8",
"kotlin-stdlib",
],
}

android_library {
name: "Aperture_io.coil-kt_coil-video",
name: "Aperture_io.coil-kt.coil3_coil-video",
sdk_version: "35",
min_sdk_version: "26",
apex_available: [
"//apex_available:platform",
"//apex_available:anyapex",
],
manifest: "io/coil-kt/coil-video/2.4.0/AndroidManifest.xml",
manifest: "io/coil-kt/coil3/coil-video/3.0.4/AndroidManifest.xml",
static_libs: [
"Aperture_io.coil-kt_coil-video-nodeps",
"Aperture_io.coil-kt_coil-base",
"Aperture_io.coil-kt.coil3_coil-video-nodeps",
"Aperture_io.coil-kt.coil3_coil-core",
"androidx.core_core-ktx",
"kotlin-stdlib-jdk8",
"kotlin-stdlib",
],
}

Expand Down
Binary file not shown.
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file removed app/libs/io/coil-kt/coil/2.4.0/coil-2.4.0.aar
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="coil.singleton" >
package="coil3.singleton" >

<uses-sdk android:minSdkVersion="21" />

Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="coil.video" >
package="coil3.core" >

<uses-sdk android:minSdkVersion="21" />

Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="coil.base" >
package="coil3.video" >

<uses-sdk android:minSdkVersion="21" />

Expand Down
Binary file not shown.
15 changes: 9 additions & 6 deletions app/src/main/java/org/lineageos/aperture/CameraActivity.kt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2022-2024 The LineageOS Project
* SPDX-FileCopyrightText: 2022-2025 The LineageOS Project
* SPDX-License-Identifier: Apache-2.0
*/

Expand Down Expand Up @@ -86,11 +86,14 @@ import androidx.lifecycle.Lifecycle
import androidx.lifecycle.lifecycleScope
import androidx.lifecycle.repeatOnLifecycle
import androidx.preference.PreferenceManager
import coil.decode.VideoFrameDecoder
import coil.load
import coil.request.ErrorResult
import coil.request.ImageRequest
import coil.size.Scale
import coil3.load
import coil3.request.ErrorResult
import coil3.request.ImageRequest
import coil3.request.crossfade
import coil3.request.error
import coil3.request.fallback
import coil3.size.Scale
import coil3.video.VideoFrameDecoder
import com.google.android.material.snackbar.Snackbar
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.flow.collectLatest
Expand Down

0 comments on commit 2e066d2

Please sign in to comment.