-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Euclid cloud access notebook #50
Add a Euclid cloud access notebook #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise it looks good, though I just give it a read through without executing it.
For now I ignored the euclid directory for all CI, so once the other PR is merged and this rebased there should not be any red statuses (but also, we don't need to trigger CI, so I added the somewhat misleading label "HTML rendering") |
182a78f
to
91619c9
Compare
Filter to only those containing "euclid": | ||
|
||
```{code-cell} ipython3 | ||
collections[['euclid' in v for v in collections['collection']]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, this and similars in the other notebooks already triggered this feature request :)
Now query this collection for our target's coordinates and search radius: | ||
|
||
```{code-cell} ipython3 | ||
img_tbl = Irsa.query_sia(pos=(coord, search_radius), collection=img_collection).to_table() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My comment on variable names still stands, use full words and descriptions. Spelling out the names helps with the narrative and there is really no need to save a couple of characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides my comment about variable names, this looks good, and that comment is not critical for merging, so let's have this in. Though I haven't run it yet.
So, let's go ahead and merge this now, and any updates to the narrative or the code can come as a follow-up.
Add a Euclid cloud access notebook 88b1350
Added a notebook to demonstrate cloud access to Euclid data (taking inspiration from Tiffany's recent notebooks)