Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Euclid cloud access notebook #50

Merged
merged 4 commits into from
Mar 16, 2025

Conversation

jaladh-singhal
Copy link
Member

Added a notebook to demonstrate cloud access to Euclid data (taking inspiration from Tiffany's recent notebooks)

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise it looks good, though I just give it a read through without executing it.

@bsipocz bsipocz added content Content related issues/PRs. html rendering / skip testing Rendering related issues/PRs. Skips tests in PRs. labels Mar 14, 2025
@bsipocz
Copy link
Member

bsipocz commented Mar 14, 2025

For now I ignored the euclid directory for all CI, so once the other PR is merged and this rebased there should not be any red statuses (but also, we don't need to trigger CI, so I added the somewhat misleading label "HTML rendering")

@bsipocz bsipocz mentioned this pull request Mar 14, 2025
@jaladh-singhal jaladh-singhal marked this pull request as ready for review March 16, 2025 02:23
Filter to only those containing "euclid":

```{code-cell} ipython3
collections[['euclid' in v for v in collections['collection']]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, this and similars in the other notebooks already triggered this feature request :)

astropy/astroquery#3254

Now query this collection for our target's coordinates and search radius:

```{code-cell} ipython3
img_tbl = Irsa.query_sia(pos=(coord, search_radius), collection=img_collection).to_table()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment on variable names still stands, use full words and descriptions. Spelling out the names helps with the narrative and there is really no need to save a couple of characters

Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comment about variable names, this looks good, and that comment is not critical for merging, so let's have this in. Though I haven't run it yet.

So, let's go ahead and merge this now, and any updates to the narrative or the code can come as a follow-up.

@bsipocz bsipocz merged commit 88b1350 into Caltech-IPAC:main Mar 16, 2025
4 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Content related issues/PRs. html rendering / skip testing Rendering related issues/PRs. Skips tests in PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants