Skip to content

FIREFLY-1759: Enable downloads for Datalink tables #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

kpuriIpac
Copy link
Contributor

@kpuriIpac kpuriIpac commented Jun 12, 2025

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1719
IFE PR: https://github.com/IPAC-SW/irsa-ife/pull/423

  • Code should be fairly straightforward, just needed a bit of work to get it going and to make existing code adapt to work directly with datalink table (as opposed to obscore/non-obscore tables containing datalink, which is what our primary use case was)

Testing:

  • Euclid: https://firefly-1759-datalink-downloads.irsakudev.ipac.caltech.edu/applications/euclid
  • do an image or object search, then extract one or more rows
  • select one or more rows in the extracted Products table and the download script
    • you may even filter the table and then try this. For example, try searching for cutouts and download all cutouts. Ensure you see cutouts in the download script in this case.
  • try changing the cutout selection (cutout size and/or search target) directly from the products table. Any of the search targets should work as expected same as they do for the image/objects table.
  • Regression testing: select a few rows and download products on the images/objects results table as well, to ensure there are no new issues introduced there.

@kpuriIpac kpuriIpac self-assigned this Jun 12, 2025
@lrebull
Copy link
Contributor

lrebull commented Jun 12, 2025

LOL my images tab no longer has a "Generate Download Script" button!!
Screenshot 2025-06-12 at 4 14 07 PM
euclid_Objects_1-curl.sh seems ok
Objects_1_Productsrow1-curl.sh has comments at the top that include 'null': "Download null from IRSA" instead of "Download Euclid from IRSA" which is what the other one has.

@lrebull
Copy link
Contributor

lrebull commented Jun 12, 2025

ok, very weird.. tried again to reproduce the missing "generate download script" button, including several times with new private window, and now it seems to be working ok. 🙄 so it's 'just me' again??

@kpuriIpac
Copy link
Contributor Author

ok, very weird.. tried again to reproduce the missing "generate download script" button, including several times with new private window, and now it seems to be working ok. 🙄 so it's 'just me' again??

if it helps..I think it had happened with me once while I was working, I immediately tried to recreate it but wasn't able to, so just dismissed it. I'll keep an eye out, though.

@kpuriIpac kpuriIpac requested a review from robyww June 16, 2025 17:48
@robyww robyww modified the milestones: 2025.4, 2025.3 Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants