Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): major dependency upgrades #76

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

fix(deps): major dependency upgrades #76

wants to merge 16 commits into from

Conversation

folkvir
Copy link
Collaborator

@folkvir folkvir commented Nov 6, 2024 •
edited
Loading

Patch note:

  • Includes an upgrade to latest versions of every packages except for chai (verison 5 is ESM only)
  • fix: remove deprecated lodash per-method packages for vulnerability fixes (by @EmilianoSanchez)
  • In prevision of the EOL maintenance period of the v18 we only support node 20+ LTS versions. Node 12 is too old for the new packages
  • Upgrade github actions to latest version
  • version upgraded to 4.0.0

@folkvir folkvir marked this pull request as draft November 6, 2024 12:24
@folkvir folkvir self-assigned this Nov 6, 2024
@folkvir folkvir requested a review from Callidon November 6, 2024 12:36
Callidon
Callidon approved these changes Nov 6, 2024
View reviewed changes
Copy link
Owner

@Callidon Callidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the changes 👍

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@folkvir folkvir marked this pull request as ready for review November 6, 2024 21:45
@folkvir
Copy link
Collaborator Author

folkvir commented Nov 12, 2024 •
edited
Loading

@Callidon I'll extract the seedrandom fix into a minor upgrade. It will allow people who want to stay on node12 to build properly without making a major upgrade.

@folkvir folkvir changed the base branch from master to bug/fix-75-seedrandom-types November 12, 2024 14:38
@folkvir folkvir changed the base branch from bug/fix-75-seedrandom-types to master November 12, 2024 14:38
@folkvir folkvir mentioned this pull request Nov 12, 2024
Merged
EmilianoSanchez and others added 4 commits November 12, 2024 21:12
@EmilianoSanchez
fix: remove deprecated lodash per-method packages for vulnerability…
17777ca 
… fixes (#78)

* Remove lodash per-method packages, which are discouraged, deprecated, and have reported vulnerabilities: https://lodash.com/per-method-packages

* Revert "Remove lodash per-method packages, which are discouraged, deprecated, and have reported vulnerabilities: https://lodash.com/per-method-packages"

This reverts commit fb59ae9.

* Replace lodash per-method packages imports with lodash direct imports
@folkvir
fix: bad lodash/ import naming
09292e2
@folkvir
v4.0.0
a03c99d
@folkvir
fix node-version to 20
0b5e0bd
@folkvir folkvir marked this pull request as draft November 12, 2024 20:44
@folkvir folkvir marked this pull request as ready for review November 13, 2024 09:58
@folkvir
Copy link
Collaborator Author

folkvir commented Nov 13, 2024

@Callidon Version 3.0.3 with the seedrandom fix has been merged and deployed. This PR is ready for a last review before merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callidon Callidon Awaiting requested review from Callidon

Assignees

@folkvir folkvir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@folkvir @Callidon @EmilianoSanchez