-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of WinUI with samples and features working #853
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really dont need this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right! Default files 😅 What do you think about the way navigation is done in the Features project? I am unsure if we should change displayrootview to not set a frame as per default since the navigation UI needs to be user supplied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer your question yes the user should supply the frame.
Does this work with desktop, uap or both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In UAP the bootstrapper creates the frame. How ever there is an overwrite that enables the user to create the frame themselves. But since the UI in UAP is setup to have the back button in the window chrome it is not an issue.
I focused on WinUI in desktop since reading about the subject that was the direction things where going and UAP was on the way out.
@KasperSK do you want to complete this pr? |
Yes but I think I need to make another commit and fix the small issues. :) |
Just wondering how far off we are from seeing this in a release? I've been using caliburn.micro in WPF apps for nearly 8 years, but I'm currently working on a WinUI app, and the amount of non-sense you have to do for basic View/ViewModel binding (and the amount of concrete references you need to have from the view to the view model) is just staggering after working in a fully auto-wired caliburn app... |
This works but navigation is a little rough around the edges, open for input on how it should be done for WinUI