Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delay to refresh #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add delay to refresh #1

wants to merge 1 commit into from

Conversation

myreen
Copy link

@myreen myreen commented Dec 14, 2017

This is an attempt at doing one of the TODOs in the TODO file.

The proposed solution is based on a conversation with @xrchz.

@xrchz
Copy link
Member

xrchz commented Sep 23, 2024

The delay added here would also delay the API server's response, which I think won't work -- the GitHub webhook that calls this, for example, probably needs it to respond fairly quickly.

It may be better to spawn a thread to do the refresh action (with delay) so the main API response can happen right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants