Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 404 page #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add a 404 page #1

wants to merge 3 commits into from

Conversation

soarn
Copy link

@soarn soarn commented May 14, 2018

i agree

@2003cah
Copy link
Member

2003cah commented May 14, 2018

Needs more coolness to be worth 10 Cool Points™

@advaith1
Copy link
Member

lol im the one who told him how to make a custom 404 page

Copy link
Collaborator

@Chew Chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fix

404.md Outdated

# Error 404

How'd you get here! Anyways, you seem to be lost.
Copy link
Collaborator

@Chew Chew May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing memes.
Also, improper grammar. How'd you get here is a question, not an exclamation.

Fix these very important errors.

also we need a cat picture

@soarn
Copy link
Author

soarn commented May 14, 2018

hmmmm

@soarn soarn changed the title 404.md 404.html May 14, 2018
@soarn
Copy link
Author

soarn commented May 14, 2018

I agree

Copy link
Collaborator

@Chew Chew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor errors

404.html Outdated
<title>404</title>
<meta charset="UTF-8">
<title>404</title>
<link href="https://fonts.googleapis.com/css?family=Ubuntu" rel="stylesheet">
</head>
<body>
<h1 style="color:DodgerBlue;"><strong>Error 404</strong></h1>
<h1 style="color:Tomato;"><b>How'd you get <sub>here?</sub> Anyways, you seem to be <sup>lost</sup>.</b></h1>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of some random tags.
I recommend italics for these as well.

404.html Outdated
@@ -1,16 +1,16 @@
---
permalink: /404.html
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

layout: default
title: Error 404

404.html Outdated
@@ -1,16 +1,16 @@
---
permalink: /404.html
---
<!DOCTYPE html>
<!DOCTYPE html>
<html>
<head>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the head tags (and the contents of it), and remove the html and body tags as these are handled by the layout

@Chew
Copy link
Collaborator

Chew commented May 14, 2018

Indention still sucks, are you using atom beautify?

@Chew Chew changed the title 404.html Add a 404 page May 14, 2018
@advaith1
Copy link
Member

why is it even in html, just do it in markdown tbh

@Chew
Copy link
Collaborator

Chew commented May 15, 2018

Html is better

@soarn
Copy link
Author

soarn commented May 21, 2018

I felt like it.

@Chew
Copy link
Collaborator

Chew commented Jan 4, 2019

7 months later how's this goin

@soarn
Copy link
Author

soarn commented Jan 31, 2019

7 months later how's this goin

dude its goin great, I have it around here someplace (I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants