This repository has been archived by the owner on Nov 22, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Visual testing views with Cypress #94
Open
gaelreyrol
wants to merge
30
commits into
develop
Choose a base branch
from
setup-cypress-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelreyrol
force-pushed
the
setup-cypress-api
branch
from
April 4, 2020 17:26
247d6cd
to
bb0067b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
Just a small question : is it complicated to move the cypress folder outside the api one ? Maybe in a /tests folder at the root of the project ?
No it is not, it just needs a few changes 😄 I'll do it tonight ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still under heavy development.
It provides visual testing for the views served by the api.
ToDo :
We should go further on track test suite but I think we might want to merge this one before.
PS: Github Actions is cool for simple things but it's actually crap when you need more, like postgres service. I can't use an newer version than 10.8 otherwise the container fails...