Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"code_challenge_methods_supported" added (https://datatracker.ietf.org/doc/html/rfc8414#section-2) #815

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smalihaider-daasi
Copy link

@smalihaider-daasi smalihaider-daasi commented May 30, 2022

…g/doc/html/rfc8414#section-2)

  • Any changes relevant to users are recorded in the CHANGELOG.md.
  • The documentation has been updated, if necessary.
  • New code is annotated.
  • Changes are covered by tests.

@@ -9,6 +9,9 @@ The format is based on the [KeepAChangeLog] project.

## 1.4.0 [2022-05-23]

### Added
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.0 is released, open a new section above for the next version please.

@schlenk
Copy link
Collaborator

schlenk commented May 30, 2022

The change itself is fine, but the output would be a lie, as the necessary PKCE functionality isn't working yet.
See #551

So unless we get PKCE working first, the list should actually be empty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants