Split workflows #16
Merged
Split workflows #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ PR Preview ready! Add ?print to the link below to preview print images
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I had in the readme instructions
Make sure to check "Allow edits by maintainers" on your fork PR, but I forgot that this option is disabled for organizations. (We can't have users create branches directly because then every time a new person submits a PR they'd have to request to become a collaborator in the repo, which will get tiring.) Without the "Allow edits" checkbox, Actions workflows do not have permissions to make commits to the fork (by default; I think a user could enable it in their fork settings). As such, this PR splits workflows into read (check-only) and write (auto-fix). The former runs on PRs, the latter runs onmainwhere it has the permissions to do so. This PR also switches from the exiftool CLI to the npm package wrapper for the CLI tool for a bit nicer ergonomics.