Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to check for broken links #4

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Conversation

vincerubinetti
Copy link
Contributor

@vincerubinetti vincerubinetti commented Feb 21, 2024

@jmcmurry

Closes #3

Note that there is a bit limitation to this, in that it only goes to the URL and checks the status code. If you go to a broken Zoom link, for example, this won't catch it because Zoom doesn't return the appropriate status code (it returns 200 as if everything is OK). For the specific case of Zoom, I could check the HTML on the page for the presence "Invalid meeting ID", but that is a brittle solution. They may change that warning text at some point, or even theoretically include the word "invalid" somewhere on a valid meeting page for some reason.

However, I ran this locally on the large Bridge2AI redirects, and it did seem to catch two non-existing Google docs. Just keep in mind that this is a rough check. There may be false positives/negatives. As such, I split it up as a separate workflow check, so if you see the "encode" workflow fail, that is a critical error you definitely need to fix, but if you see the "check" workflow fail, you may be able to ignore that.

@vincerubinetti
Copy link
Contributor Author

@falquaddoomi Poke for review. Not urgent at all, but I'd like to close the loop if you have time.

Copy link

@falquaddoomi falquaddoomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see anything that would block approval, but I left a comment about core.js.

core.js Outdated Show resolved Hide resolved
.github/workflows/deploy.yaml Show resolved Hide resolved
@vincerubinetti vincerubinetti merged commit c03c54c into main Mar 13, 2024
1 of 2 checks passed
@vincerubinetti vincerubinetti deleted the check-broken branch March 13, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add periodic check for broken links
2 participants