Skip to content

Add merch page #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add merch page #809

wants to merge 9 commits into from

Conversation

LMBishop
Copy link
Contributor

No description provided.

@LMBishop LMBishop requested a review from a team as a code owner April 26, 2025 16:32
Copy link
Member

@Thatsmusic99 Thatsmusic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holy shit let him cook, this genuinely looks epic

Some thoughts:

  • Do we want an extra bit for shirts as well to have something there once other merch goes off sale?
  • Any thoughts on adding it as a menu bar item?
  • The photos are incredibly high quality and slow to load - they might need compressing

@LMBishop
Copy link
Contributor Author

LMBishop commented Apr 26, 2025

  • Do we want an extra bit for shirts as well to have something there once other merch goes off sale?

Maybe. Or ducks, I think we still have those. Or even hoodies, just listed as "not on sale right now"

  • Any thoughts on adding it as a menu bar item?

That menu bar would be getting too long, we would need to get rid of something. Maybe put calendar under events and shorten newsletter to just 'News'

@MattyTheHacker
Copy link
Member

Not sure how keen I would be on removing the calendar from the menu bar, imo it's something we should push more rather than less. Merch could be added as a dropdown under the "About" tab?

@LMBishop
Copy link
Contributor Author

Not sure how keen I would be on removing the calendar from the menu bar, imo it's something we should push more rather than less.

It's not removed, it's just under the events tab. Also it is also already linked in a rather conspicuous way on the (totally not biased) much more appealing events page

I've pushed another change which shuffles around the nav bar, take another look and see if you like it. Also the hamburger menu was completely busted on mobile which I have now fixed

@MattyTheHacker
Copy link
Member

MattyTheHacker commented Apr 28, 2025

link for all merch will always be: https://www.guildofstudents.com/shop/catalogue/ComputerScienceSoc/

annoyingly we cannot link to individual items within that page, otherwise happy to approve

@MattyTheHacker MattyTheHacker enabled auto-merge (squash) April 29, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants