Convert to multiplatform plugin #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMBishop
changed the title
MattyTheHacker
previously approved these changes
Aug 31, 2024
|
|
||
| private final BukkitCSSMinecraftPlugin plugin; | ||
|
|
||
| public CSSMinecraftLoader() { |
There was a problem hiding this comment.
Is this constructor in Bukkit/Paper ever called? My memory on plugin initialisation is quite rusty.
There was a problem hiding this comment.
common/src/main/java/com/cssbham/cssminecraft/common/config/source/YamlConfigSource.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/cssbham/cssminecraft/common/discord/client/JDADiscordClient.java
Outdated
Show resolved
Hide resolved
Comment on lines
+10
to
+30
| public static PermissionPluginService any() { | ||
| String[] plugins = new String[]{ "LuckPerms" }; | ||
| for (String plugin : plugins) { | ||
| try { | ||
| return forPlugin(plugin); | ||
| } catch (RuntimeException ignored) { } | ||
| } | ||
| return new StubPermissionPluginService(); | ||
| } | ||
|
|
||
| public static PermissionPluginService forPlugin(String plugin) { | ||
| try { | ||
| return switch (plugin) { | ||
| case "LuckPerms" -> checkClassAndBuild("net.luckperms.api.LuckPermsProvider", LuckPermsPermissionPluginService.class); | ||
| default -> new StubPermissionPluginService(); | ||
| }; | ||
| } catch (ClassNotFoundException | InstantiationException | IllegalAccessException | NoSuchMethodException | | ||
| InvocationTargetException e) { | ||
| throw new RuntimeException(String.format("Permission plugin %s is not available", plugin)); | ||
| } | ||
| } |
There was a problem hiding this comment.
Would we rather have some kind of registration for permission services rather than hardcoding them?
There was a problem hiding this comment.
I don't see the case where permission plugins will be registering themselves here. But if in the future we do have 30 different permission plugins we want to integrate with, then this factory could become abstract and a concrete version can be provided at runtime (rather than having an explicit list of supported plugins here)
MattyTheHacker
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This has the ultimate goal of making it easier to port to other platforms, or backport to older Minecraft versions where necessary