Election pages

[gunmack]

Thought I'd make a draft of what I have so far:

• Some background on elections and links to register and vote (they dont point anywhere else, yet)

• List of past election info

[gunmack]

• From what I understand, I should be calling the backend urls which will respond with data from the database. Also same logic for sending data to the backend.

• I tried running the FastAPI app and then calling it from the frontend but I kept getting blocked by CORS. Assuming there's a specific way it's all set up.

• Also, about using mock data; do I load a test database with the Election tables and add mock data to that? or did you mean something else?

[EarthenSky]

This looks awesome so far!

From what I understand, I should be calling the backend urls which will respond with data from the database. Also same logic for sending data to the backend.

100%! I have a list of API endpoints from sean's PR, which I'll be adding to. But if you feel that an endpoint should exist, feel free to assume it exists & ask me for it.

I tried running the FastAPI app and then calling it from the frontend but I kept getting blocked by CORS. Assuming there's a specific way it's all set up.

Oh heck. There's a configuration in webpack that should address this issue if I recall correctly. I hope this isn't related to what you mentioned before about your ubuntu version not working nicely with webpack... I'll look into this & update you if I find anything!

Also, about using mock data; do I load a test database with the Election tables and add mock data to that? or did you mean something else?

For developing the backend, I'll be loading the database with mock data for my own testing. For developing the frontend, you'll want to write functions that don't actually make any web requests, but which respond with up-to-date data.

The idea is that your mock data will be pretty low effort & you'll be able to confirm most of the behaviour of the application without being blocked by the backend working. After the backend is working, I'll have loaded some mock data into the db for testing, with which you can actually introduce the API calls.

[EarthenSky]

lgtm!

[gunmack]

So I got some JSON data from chat gpt and I tried to use the fields as specified in the database schema

• Title of each election is also stored as a slug
• The titles are displayed in a list

• Tried to replicate the old website
• For the JSON fields, had to add a Position field(s) inside each election ( I didn't see a positions field in the schema )
• TODO: add a field to store candidate's social media links

Snippets from the JSON file

[EarthenSky]

Sorry for the delay in reviewing! Feel free to annoy me and I'll happily throw you a review.

The pages all look really nice! The only important change is that multiple elections can be registered for at the same time.

An fyi that speeches will eventually be stored in html, but that's a problem for future us :)

[EarthenSky]

what's this 100ms wait for? I'd assume session storage doesn't need a timeout to be accessed?

[gunmack]

I copied it from the Profile page lol. Regardless, it's not needed here because the /register page also deals with that. I'll remove it.

[EarthenSky]

It's possible for multiple elections to exist at once. Right now there's actually the general & sfss council rep elections going on. Could we make it so that registering is elections/:slug/register?

In this case, we'd also want to change the URL from /past_elections/ to /elections/.

The backend will deal with the complexity of there being multiple elections run at once; you should just have to call the endpoints using the current election's slug.

[gunmack]

I think you reviewed outdated files. I already implemented the changes you suggested lol.

[gunmack]

so when the frontend calls for old election data, assuming the backend will sort elections in order and only send previous elections? Because I added some extra booleans in the json data to mimic that ( just for testing).

Will the endpoint only send previous elections or will it also include currently in progress ones?

[gunmack]

It's possible for multiple elections to exist at once. Right now there's actually the general & sfss council rep elections going on. Could we make it so that registering is elections/:slug/register?

Should this be linked through the list of elections? Like the list that contains old elections will also contain the currently in progress ones, but only let users register when they click on them?

[EarthenSky]

Will the endpoint only send previous elections or will it also include currently in progress ones?

Up to you! You can give me whatever requests you think are easiest. I'd imagine we include all elections, including in-progress ones. However, we'd probably include a property in the json that says what stage an election is at (ended, voting, registration) so the frontend can display the information however you wish.

[EarthenSky]

only let users register when they click on them?

there will be a backend endpoint that looks something like POST /api/elections/:slug/register, and a frontend page /elections/:slug/register

I imagine that when someone navigates to the election page /elections/:slug/register you first check the endpoint GET /api/elections/:slug/info, then display "sorry this election is no longer accepting nominations" if the election is no longer in the registration period. The result of the info endpoint will say what the status of the election is.