forked from bcherny/json-schema-to-typescript
-
Notifications
You must be signed in to change notification settings - Fork 0
Merge v14.0.4 (+ readme updates) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmower-csnw
commented
May 23, 2024
- Merge the latest upstream, see procedure below.
- This v14.0.4 with two additional commits because they are only readme updates.
* feat: support `customName` options * feat: support nullish name for `customName`
Doing this to avoid warnings when running `npm i`, since @typescript-eslint still requires 8.56.
* feat: [577] Add yml support * Update README.md Co-authored-by: Boris Cherny <[email protected]> * feat: [577] Add yml support * feat: [577] Rebase - master --------- Co-authored-by: Boris Cherny <[email protected]>
It is now deprecated as the types are now part of the prettier lib. Fixes bcherny#593 Co-authored-by: Pascal Corpet <[email protected]>
speck14
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdmower-csnw Review + (used BeyondCompare to diff these changes against the upstream)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.