Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially enable RHF v4.0 evaluation metrics, stability/typing fixes #476

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Partially enable RHF v4.0 evaluation metrics, stability/typing fixes #476

wants to merge 15 commits into from

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Mar 10, 2025 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Enables the new evaluation metrics introduced in RHF v4.0.0
  • Adjusts the testing suite to verify more evaluation metrics
  • More clearly indicates the expected types in many call signatures and docstrings

Does this PR introduce a breaking change?

No. New functionality has been added.

Other information:

This needs to be merged before the next minor release (#462)

@Zeitsperre Zeitsperre added the enhancement New feature or request label Mar 10, 2025
@coveralls
Copy link

coveralls commented Mar 10, 2025 •
edited
Loading

Coverage Status

coverage: 82.037%. first build
when pulling 4831275 on upgrade40
into 1c14e4c on master.

@github-actions github-actions bot added the docs label Mar 18, 2025
@Zeitsperre Zeitsperre changed the title Enable RHF v4.0 evaluation metrics Enable RHF v4.0 evaluation metrics, stability/typing fixes Mar 18, 2025
@Zeitsperre Zeitsperre marked this pull request as ready for review March 18, 2025 18:20
@Zeitsperre Zeitsperre requested a review from huard March 18, 2025 18:21
@Zeitsperre Zeitsperre changed the title Enable RHF v4.0 evaluation metrics, stability/typing fixes Partially enable RHF v4.0 evaluation metrics, stability/typing fixes Mar 18, 2025
huard
huard approved these changes Mar 19, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees

@huard huard

@Zeitsperre Zeitsperre

Labels
docs enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @huard