Modifications to make ScotsCorr work in Korp 9 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpack.common.js: - Add a rule to copy corpus_info/*.json in the configuration to corpus_info/ (corpus-specific information).
Add plugin hook points to be used in plugin cqp_between_tokens. app/scripts/model.js: - BaseProxy.expandCQP: Let plugins filter the expanded CQP. app/scripts/search_controllers.js - ExtendedSearch: Let plugins filter the extended search CQP expression and act when corpus selection is changed. app/scripts/util.js - CorpusListing.constructor, .select: Let plugins act on CorpusListing after constructing it and when selecting corpora.
|
@mmatthiesencsc, @aajarven, @Traubert: Could you please merge this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed to make ScotsCorr work in Korp 9, along with changes in the backend, frontend plugins and frontend configuration:
corpus_infodirectory in the configuration to the corresponding location in Webpack, needed for the ScotsCorr word list.cqp_between_tokens, used by ScotsCorr (and LA-murre and ELFA).