Skip to content

Change the Spezi icon in Onboarding to a star #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Conversation

vishnuravi
Copy link
Member

Change the Spezi icon in Onboarding to a star

♻️ Current situation & Problem

The current Spezi icon is an iPhone which is boring.

⚙️ Release Notes

This PR changes the icon to a star, which is much cooler looking. It also serves as a great demo for how to resolve a merge conflict in class.

📚 Documentation

  • N/A

✅ Testing

  • N/A

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (395ed90) to head (548b435).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          21       21           
  Lines         697      697           
=======================================
  Hits          605      605           
  Misses         92       92           
Files with missing lines Coverage Δ
CS342ExampleApplication/Onboarding/Welcome.swift 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395ed90...548b435. Read the comment docs.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the PR; would be great to resolve the merge conflict before we merge it. Your choice what we should keep here (cats or stars) 🚀

@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Jan 29, 2025
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

@vishnuravi vishnuravi merged commit a4778d6 into main Jan 29, 2025
5 of 6 checks passed
@vishnuravi vishnuravi deleted the update-icon branch January 29, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants