changes to icons and description on welcome page #5
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 38.12% 38.62% +0.51%
==========================================
Files 31 31
Lines 976 984 +8
==========================================
+ Hits 372 380 +8
Misses 604 604
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Hi @tulika-jha ,
Thank you for the PR and the improvements. It's a great first version that only needs some more very minor changes!
Please use the PR template that is in the Pull Request description. Also, fill out the Documentation and Testing part of the PR template, it's completely fine to state that you didn't do anything in that aspect within your PR.
Please also read through the "Keeping your pull request in sync with the base branch" documentation to ensure that your branch is up to date with the main branch before you merge it into the main branch.
Please re-request a review once you updated the branch to the main branch, you have updated the PR description, and addressed some of the in-line comments and I am happy to approve the PR to get it merged 🚀
Keeping the feature branch up to date with the main branch.
There was a problem hiding this comment.
Thanks for incorporating the change requests, great work @tulika-jha! 🚀
For the next PRs: Feel free to resolve discussion items (so my inline comments) as soon as you fixed them 👍 In this PR, I did this for you :)
PR is ready to merge!
|
@tulika-jha Your PR is ready to merge, please merge the PR by the beginning of class today! 🚀 |
|
@philippzagar Thanks for approving! Merging the PR now |
Assignment 1 task 2
♻️ Current situation & Problem
The two onboarding views need to be customised for the Stronger app.
⚙️ Release Notes
Customized the two onboarding views of the app with information pertaining to the Stronger app.
📚 Documentation
Did not add to documentation.
✅ Testing
Did not add new tests.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: