Task 1 tkanell #10
Merged
Task 1 tkanell #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 38.62% 40.22% +1.60%
==========================================
Files 31 31
Lines 984 1017 +33
==========================================
+ Hits 380 409 +29
- Misses 604 608 +4
Continue to review full report in Codecov by Sentry.
|
aydinzahedi
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Great job with your PR! The icon wouldn't show up, then I saw that in the file Stronger/Resources/Assets.xcassets/AppIcon.appiconset/Contents.json, the file is called new_app_icon. If you change that to be the correct file name, it should work.
Also, just be sure to fill out the documentation template next time.
Great work!
aydinzahedi
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task 1
♻️ Current situation & Problem
Add new Icon
Contacts
and change color.
📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
✅ Testing
Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: