Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Onboarding Tests #58

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Add Onboarding Tests #58

merged 7 commits into from
Mar 13, 2024

Conversation

YurenSUN
Copy link
Contributor

@YurenSUN YurenSUN commented Mar 11, 2024

Add Onboarding Tests

♻️ Current situation & Problem

Currently, we are missing code coverages for the onboarding flow. Therefore, this PR resued the onboarding flow tests from the Spezi template App, modified, and add additional functions tailored to our App to have the onboarding flow covered.

⚙️ Release Notes

  • Add tests for onboarding flow.
  • Quickly check whether the licensing is displayed as expected.
  • Fix a small bug so the page asks for the notification permission will not show anymore once the notification is enabled.

📚 Documentation

Related comments are added to the test codes.

✅ Testing

This PR only adds tests to the existing App.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@YurenSUN YurenSUN marked this pull request as ready for review March 13, 2024 02:34
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (f040e27) to head (ca14b12).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #58       +/-   ##
===========================================
+ Coverage   54.95%   83.07%   +28.12%     
===========================================
  Files          54       54               
  Lines        2990     2993        +3     
===========================================
+ Hits         1643     2486      +843     
+ Misses       1347      507      -840     
Files Coverage Δ
PICS/Onboarding/OnboardingFlow.swift 97.50% <100.00%> (+0.21%) ⬆️
PICS/PICSDelegate.swift 95.24% <100.00%> (ø)

... and 30 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f040e27...ca14b12. Read the comment docs.

@YurenSUN YurenSUN requested a review from karansoin March 13, 2024 03:37
Copy link
Contributor

@czhang771 czhang771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@YurenSUN YurenSUN merged commit f1b4e0c into main Mar 13, 2024
7 checks passed
@YurenSUN YurenSUN deleted the onboarding-tests branch March 13, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants