Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts/Appointments Testing #55

Merged
merged 15 commits into from
Mar 13, 2024
Merged

Contacts/Appointments Testing #55

merged 15 commits into from
Mar 13, 2024

Conversation

akanshyabhat
Copy link
Contributor

@akanshyabhat akanshyabhat commented Mar 8, 2024

Contacts/Appointments Testing + Final Changes (Timeline)

♻️ Current situation & Problem

There were some untested lines of code in the Contacts and Appointments tabs.

⚙️ Release Notes

  • Removed the left arrowhead from timeline based on feedback from PIs

✅ Testing

  • Added a UI test to Contacts and a UI test to Appointments
  • Added a functional test for the code in AppointmentInformation
  • Reschedule the dates to also trigger the notification handling

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.26%. Comparing base (f1b4e0c) to head (fb5e21b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   83.07%   82.26%   -0.80%     
==========================================
  Files          54       54              
  Lines        2993     2987       -6     
==========================================
- Hits         2486     2457      -29     
- Misses        507      530      +23     
Files Coverage Δ
PICS/Appointment/TimelineView.swift 98.12% <100.00%> (-0.10%) ⬇️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b4e0c...fb5e21b. Read the comment docs.

@akanshyabhat akanshyabhat changed the title Contacts Testing Contacts/Appointments Testing Mar 13, 2024
@akanshyabhat akanshyabhat requested a review from YurenSUN March 13, 2024 04:38
Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look great to me, maybe just need to revert the changes to the build scheme and maybe also revert changes in deleting the DEVELOPMENT_TEAM as we currently have all the tests (both Github PR tests and the beta deployment tests) and not sure whether changing them to an empty one might break any tests or deployment?

PICS.xcodeproj/xcshareddata/xcschemes/PICS.xcscheme Outdated Show resolved Hide resolved
PICS.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
PICS.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
@akanshyabhat akanshyabhat merged commit ef56301 into main Mar 13, 2024
7 checks passed
@akanshyabhat akanshyabhat deleted the akanshya---testing branch March 13, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants