Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appointments - Dark Mode #53

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Appointments - Dark Mode #53

merged 8 commits into from
Mar 12, 2024

Conversation

akanshyabhat
Copy link
Contributor

@akanshyabhat akanshyabhat commented Mar 8, 2024

Appointments - Dark Mode

♻️ Current situation & Problem

The appointments page had hardcoded colors which made certain components not show in Dark Mode. I have modified the colors so it works in both views.

⚙️ Release Notes

  • Edit colors to use system colors instead of straight white or black

📚 Documentation

N/A

✅ Testing

Passes all tests

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.95%. Comparing base (bdb5a8e) to head (3c24dc9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   54.89%   54.95%   +0.07%     
==========================================
  Files          54       54              
  Lines        2986     2990       +4     
==========================================
+ Hits         1639     1643       +4     
  Misses       1347     1347              
Files Coverage Δ
PICS/Appointment/AppointmentBlock.swift 64.41% <100.00%> (ø)
PICS/Appointment/AppointmentView.swift 54.44% <100.00%> (+1.19%) ⬆️
PICS/Appointment/TimelineView.swift 98.22% <100.00%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdb5a8e...3c24dc9. Read the comment docs.

Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a small comment to revert changing to the old ResearchKit version as we need the newer version to make the reaction time task work.

@akanshyabhat akanshyabhat enabled auto-merge (squash) March 12, 2024 23:48
@akanshyabhat akanshyabhat merged commit f040e27 into main Mar 12, 2024
7 checks passed
@akanshyabhat akanshyabhat deleted the required_items branch March 12, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants