-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appointments - Dark Mode #53
Conversation
…nto required_items
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 54.89% 54.95% +0.07%
==========================================
Files 54 54
Lines 2986 2990 +4
==========================================
+ Hits 1639 1643 +4
Misses 1347 1347
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a small comment to revert changing to the old ResearchKit version as we need the newer version to make the reaction time task work.
Appointments - Dark Mode
♻️ Current situation & Problem
The appointments page had hardcoded colors which made certain components not show in Dark Mode. I have modified the colors so it works in both views.
⚙️ Release Notes
📚 Documentation
N/A
✅ Testing
Passes all tests
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: