Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandleTaskResult Update for ReactionTest #51

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Conversation

czhang771
Copy link
Contributor

@czhang771 czhang771 commented Mar 7, 2024

Updating HandleTaskResult for ReactionTest

♻️ Current situation & Problem

  • Use decodable to parse together DeviceMotion data to find average reaction time from 5 attempts
  • Also fixed Medication Page so user must upload picture before continuing

⚙️ Release Notes

  • User can now complete the ReactionTime test with 5 attempts and get data visualizations on average reaction time
  • Note: ReactionTime test does not work on the simulator so there is a constant value of 0.5 sections set for the reaction time if run on the simulator

📚 Documentation

  • Added DeviceMotionModel file to model the data

✅ Testing

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 36.18%. Comparing base (a7c6c16) to head (a9a8706).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   36.38%   36.18%   -0.19%     
==========================================
  Files          54       54              
  Lines        2961     2977      +16     
==========================================
  Hits         1077     1077              
- Misses       1884     1900      +16     
Files Coverage Δ
PICS/Onboarding/ContentView.swift 0.00% <0.00%> (ø)
PICS/Onboarding/Medication.swift 0.00% <0.00%> (ø)
PICS/Assessment/ReactionTime.swift 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c6c16...a9a8706. Read the comment docs.

@czhang771 czhang771 requested a review from YurenSUN March 8, 2024 00:46
Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! YEAH we made it!

@czhang771 czhang771 enabled auto-merge (squash) March 8, 2024 01:02
@czhang771 czhang771 merged commit 3be7d9a into main Mar 8, 2024
6 checks passed
@czhang771 czhang771 deleted the Update-ReactionTimeTest branch March 8, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants