Skip to content

Adding Stroop Test + Revamp of Cognitive Assessments Page #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Mar 2, 2024

Conversation

karansoin
Copy link
Contributor

Adding Stroop Test + Revamp of Cognitive Assessments Page

♻️ Current situation & Problem

Current Assessment Page contains only the trail making test, and UI is not well formatted and intuitive/clean. Also, the current assessments show the same messages and UI before completing and after completing the assessment, so UI does not update with state changes. Also, UI of questionnaire scheduling is currently not fully centered and not well formatted

⚙️ Release Notes

  • Added the Stroop Test to the Assessments Page
  • Revamped container UI for both Stroop Test and Assessments Page, adding global variables for reusability
  • Created a state pre-completion to show a specific set of UI prompting you to complete the assessment, that is active if the assessment has not been completed
  • Created a state post-completion of assessment with a visualization summarizing your test results
  • Created and renamed a button after completion of assessment to be able to retake the test if patient would like to.
  • Updated questionnaire descriptions which give more clear guidance and instructions
  • Cleaned up formatting for questionnaire scheduling
  • Cleaned up all commented out code, added necessary comments, and removed unnecessary comments
  • Also restructured/rewrote code of Assessments.swift to comply with SwiftLint specifications
Screenshot 2024-03-01 at 12 29 08 AM Screenshot 2024-03-01 at 12 28 10 AM Screenshot 2024-03-01 at 12 29 32 AM

📚 Documentation

Main Documentation Referenced:
https://github.com/StanfordSpezi/.github/blob/main/DOCUMENTATIONGUIDE.md
https://researchkit.org/docs/docs/ActiveTasks/ActiveTasks.html
https://github.com/StanfordBDHG/ResearchKit/blob/main/Sources/ResearchKitSwiftUI/ORKOrderedTaskView.swift

All logic and code explanations in code comments in Assessments folder files

✅ Testing

  • Did a complete run through of assessments to verify functionality as expected without unexpected errors/glitches
  • No additional UI/Unit Tests added as current tests are extensive

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 1.05820% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 39.72%. Comparing base (f8d2bcc) to head (b85340c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   40.21%   39.72%   -0.49%     
==========================================
  Files          48       46       -2     
  Lines        2191     2211      +20     
==========================================
- Hits          881      878       -3     
- Misses       1310     1333      +23     
Files Coverage Δ
PICS/Onboarding/OnboardingFlow.swift 96.56% <100.00%> (ø)
PICS/Onboarding/Onboarding_Questionnaire.swift 0.00% <0.00%> (ø)
PICS/Schedule/EventContextView.swift 0.00% <0.00%> (ø)
PICS/Schedule/ScheduleView.swift 4.71% <0.00%> (-0.67%) ⬇️
PICS/Assessment/StroopTest.swift 0.00% <0.00%> (ø)
PICS/Assessment/Assessments.swift 5.04% <0.90%> (-6.96%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d2bcc...b85340c. Read the comment docs.

Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for refining the UI.

@karansoin karansoin merged commit c4910c1 into main Mar 2, 2024
@karansoin karansoin deleted the KaranSoin-Assessment-Changes branch March 2, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants