Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Timeline to Appointments #35

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Conversation

akanshyabhat
Copy link
Contributor

@akanshyabhat akanshyabhat commented Feb 27, 2024

Adding the Timeline to Appointments

♻️ Current situation & Problem

Adding a timeline to simplify understanding (especially for individuals with cognitive impairments) in the appointments view
Screenshot 2024-03-06 at 9 06 18 PM

⚙️ Release Notes

  • Used Path to draw the lines
  • Blue dot indicates where the patient is in their journey
  • Updates based on date

📚 Documentation

This is primarily a UI change for an additional visualization of the patient's timeline.

✅ Testing

The tests all pass.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 98.26087% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 44.81%. Comparing base (c98b2f5) to head (ba9ff13).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   41.42%   44.81%   +3.39%     
==========================================
  Files          41       42       +1     
  Lines        1818     1933     +115     
==========================================
+ Hits          753      866     +113     
- Misses       1065     1067       +2     
Files Coverage Δ
PICS/Appointment/AppointmentBlock.swift 94.74% <ø> (ø)
PICS/Appointment/AppointmentView.swift 95.56% <100.00%> (+0.56%) ⬆️
PICS/Appointment/Appointments.swift 100.00% <ø> (ø)
PICS/Appointment/TimelineView.swift 98.19% <98.19%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c98b2f5...ba9ff13. Read the comment docs.

Copy link
Contributor

@YurenSUN YurenSUN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me and also works well on my side! We might consider using localizable strings for "Appointment 1", "Appointment 2", and "Your Timeline", but could be good to have features merged first as we can also do minor fixes later! 🚀

PICS/Appointment/TimelineView.swift Outdated Show resolved Hide resolved
@akanshyabhat akanshyabhat merged commit 9cd44c0 into main Feb 28, 2024
7 checks passed
@akanshyabhat akanshyabhat deleted the akanshya-creatingTimeline branch February 28, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants