-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PICS ASSIGNMENT 1 TASK 4: added and modified questionnaire #3
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 33.12% 39.98% +6.86%
==========================================
Files 30 30
Lines 933 933
==========================================
+ Hits 309 373 +64
+ Misses 624 560 -64
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karansoin, nice job creating a new questionnaire with the Phoenix Survey Builder and adding it to your app!
One suggestion I will make is to change the keys for the title and description of your questionnaire in the localizable file, because they are still set to TASK_SOCIAL_SUPPORT_QUESTIONNAIRE_TITLE
and TASK_SOCIAL_SUPPORT_QUESTIONNAIRE_DESCRIPTION
. I would update these to reflect the name of your new survey.
Please make sure you also sync your branch with the changes on main.
Great work overall!
Nice job with the updates @karansoin! |
…S342/2024-PICS into karansoin-assign1-task4
Added an appropriate PROM Questionnaire
♻️ Current situation & Problem
The current app contains a questionnaire that is not relevant
⚙️ Release Notes
Added a new json file for the new PROM questionnaire and integrated the new questionnaire into the app
📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
Referred to the SpeziQuesionnaire documentation (https://swiftpackageindex.com/StanfordSpezi/SpeziQuestionnaire/documentation/speziquestionnaire) and (https://github.com/StanfordSpezi/SpeziQuestionnaire) for more details on how questionnaires could be displayed.
(https://swiftpackageindex.com/StanfordSpezi/SpeziScheduler/documentation/spezischeduler) and (https://github.com/StanfordSpezi/SpeziScheduler) for more details on how repeated tasks can be easily scheduled through SpeziScheduler.
✅ Testing
No automated testing yet
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: