Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PICS ASSIGNMENT 1 TASK 4: added and modified questionnaire #3

Merged
merged 10 commits into from
Jan 22, 2024

Conversation

karansoin
Copy link
Contributor

Added an appropriate PROM Questionnaire

♻️ Current situation & Problem

The current app contains a questionnaire that is not relevant

⚙️ Release Notes

Added a new json file for the new PROM questionnaire and integrated the new questionnaire into the app

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
Referred to the SpeziQuesionnaire documentation (https://swiftpackageindex.com/StanfordSpezi/SpeziQuestionnaire/documentation/speziquestionnaire) and (https://github.com/StanfordSpezi/SpeziQuestionnaire) for more details on how questionnaires could be displayed.
(https://swiftpackageindex.com/StanfordSpezi/SpeziScheduler/documentation/spezischeduler) and (https://github.com/StanfordSpezi/SpeziScheduler) for more details on how repeated tasks can be easily scheduled through SpeziScheduler.

✅ Testing

No automated testing yet

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4747eae) 33.12% compared to head (fd02a46) 39.98%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   33.12%   39.98%   +6.86%     
==========================================
  Files          30       30              
  Lines         933      933              
==========================================
+ Hits          309      373      +64     
+ Misses        624      560      -64     
Files Coverage Δ
PICS/Schedule/PICSScheduler.swift 82.15% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4747eae...fd02a46. Read the comment docs.

@vishnuravi vishnuravi self-requested a review January 19, 2024 01:26
Copy link
Member

@vishnuravi vishnuravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @karansoin, nice job creating a new questionnaire with the Phoenix Survey Builder and adding it to your app!

One suggestion I will make is to change the keys for the title and description of your questionnaire in the localizable file, because they are still set to TASK_SOCIAL_SUPPORT_QUESTIONNAIRE_TITLE and TASK_SOCIAL_SUPPORT_QUESTIONNAIRE_DESCRIPTION. I would update these to reflect the name of your new survey.

Please make sure you also sync your branch with the changes on main.

Great work overall!

@karansoin karansoin requested a review from vishnuravi January 21, 2024 23:48
@vishnuravi
Copy link
Member

Nice job with the updates @karansoin!

@karansoin karansoin merged commit ff4e43c into main Jan 22, 2024
8 checks passed
@karansoin karansoin deleted the origin/karansoin-assign1-task4 branch January 22, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants